Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

zinnia: fix reporting AbortErrors to Sentry#679

Merged
juliangruber merged 2 commits intomainfrom
fix/sentry-ignore-abort-errors
Feb 10, 2025
Merged

zinnia: fix reporting AbortErrors to Sentry#679
juliangruber merged 2 commits intomainfrom
fix/sentry-ignore-abort-errors

Conversation

@juliangruber
Copy link
Member

Fixes https://space-meridian.sentry.io/issues/5857510005/?query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=freq&statsPeriod=14d&stream_index=1 and more.

Before this change, an abort error will always be reported to Sentry. Situations that trigger an abort:

  • Module has been inactive (I have added error handling specifically for this here)
  • Any other error happened (this is already being reported to Sentry, no need to report the resulting abort error)
  • Restarting Zinnia after updating source files (not an error)

Looking at Sentry, and especially the view of all issues sorted by number of events, this is the biggest offender that is still happening.

@juliangruber juliangruber requested a review from bajtos February 10, 2025 17:11
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this issue!

@juliangruber juliangruber merged commit 85476b6 into main Feb 10, 2025
18 checks passed
@juliangruber juliangruber deleted the fix/sentry-ignore-abort-errors branch February 10, 2025 17:32
@juliangruber
Copy link
Member Author

@sentry
Copy link

sentry bot commented Feb 21, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ReferenceError: module is not defined Timeout._onTimeout(zinnia) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants