This repository was archived by the owner on Jun 30, 2025. It is now read-only.
fix: prevent reporting expected module restart errors to Sentry (#599)#761
Closed
Hany-Almnaem wants to merge 2 commits intoCheckerNetwork:mainfrom
Closed
fix: prevent reporting expected module restart errors to Sentry (#599)#761Hany-Almnaem wants to merge 2 commits intoCheckerNetwork:mainfrom
Hany-Almnaem wants to merge 2 commits intoCheckerNetwork:mainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
|
Thank you for the pull request, @Hany-Almnaem. It is unfortunately no longer relevant, because we decided to remove the Sentry integration - see #765. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #599 by ensuring we no longer report expected module restart errors (due to inactivity) to Sentry.
Changes
maybeReportErrorToSentry()to support dependency injection for testabilityreportToSentry: falseSentry.captureExceptionand used DI to allow isolated unit testingmaybeReportErrorToSentry()using a spySentry) with functional imports (captureException,withScope)