Skip to content
This repository was archived by the owner on Jan 7, 2026. It is now read-only.

chore: configure neostandard + prettier#167

Closed
bajtos wants to merge 4 commits intomainfrom
neostandard-prettier
Closed

chore: configure neostandard + prettier#167
bajtos wants to merge 4 commits intomainfrom
neostandard-prettier

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Apr 2, 2025

I copied eslint and prettier configuration from https://github.com/CheckerNetwork/assert-ok-response

I split the changes into two commits to make this pull request easier to review. The second commit contains linting fixes automatically generated by eslint and prettier.

  • chore: configure neostandard + prettier
  • chore: npm run lint:fix

UPDATE 2025-04-22

I adopted @checkernetwork/prettier-config in 877876e.

Links:

@bajtos bajtos marked this pull request as draft April 2, 2025 08:59
bajtos added 2 commits April 2, 2025 11:01
Upgrade from `standard` to `neostandard` + `prettier`.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos force-pushed the neostandard-prettier branch from a1436d6 to 772c10a Compare April 2, 2025 09:01
@bajtos bajtos marked this pull request as ready for review April 2, 2025 09:07
@bajtos bajtos marked this pull request as draft April 2, 2025 11:11
@bajtos
Copy link
Member Author

bajtos commented Apr 2, 2025

This is blocked, we need to resolve the discussion about the desired Prettier config in CheckerNetwork/node#710

@bajtos bajtos added the blocked label Apr 2, 2025
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber April 22, 2025 14:15
@bajtos bajtos marked this pull request as ready for review April 22, 2025 14:23
* head --> [ ] -\
* ↓ | ... | entries visited in this walk ↓ | [ ] -/ ↓ tail --> [ ] -\
* ↓ | ... | entries NOT visited yet ↓ | [ ] -/ ↓ lastHead --> [ ] -\
* ↓ | ... | entries visited in the previous walks ↓ | [ ] -/ ↓ (null)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: I need to revert this formatting change.

@bajtos bajtos marked this pull request as draft April 22, 2025 14:28
@bajtos
Copy link
Member Author

bajtos commented Apr 23, 2025

Superseded by #178

@bajtos bajtos closed this Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants