This repository was archived by the owner on Mar 3, 2020. It is now read-only.
Conversation
beatriz1304
force-pushed
the
bia/master-with-map
branch
from
adfcd48 to
79f4e65
Compare
douglasgimli
approved these changes
Aug 20, 2018
Member
douglasgimli
left a comment
douglasgimli
left a comment
There was a problem hiding this comment.
Awesome work, small inline comments :) 👏
| import Mapbox from '_components/organisms/mapbox-map' | ||
| import MarkerList from '_components/molecules/marker-list' | ||
|
|
||
| const road = 'ROADMAP' |
Member
There was a problem hiding this comment.
Can't you create an enum of the options and receive it as prop?
| )} | ||
| </Fragment> | ||
| ) : ( | ||
| <div>Loading map</div> |
Member
There was a problem hiding this comment.
Maybe you should receive this message as a prop too, because the app could be in Portuguese :)
|
|
||
| class Mapbox extends Component { | ||
| state = { | ||
| viewport: { |
Member
There was a problem hiding this comment.
Why is this hardcoded as state and not as prop values?
| @@ -0,0 +1,9 @@ | |||
| export const isBrowser = typeof window !== 'undefined' | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...