Merged
Conversation
- Protected main: require PR + CI (PHP Lint, Frontend Build, Docker) - Protected develop: require PR + CI (PHP Lint, Frontend Build) - Updated PR template with Git Flow branch types and testing checklist - Rewrote CONTRIBUTING.md with full Git Flow workflow, branch naming, and development setup instructions - Repo is now public (BSL licensed) Co-authored-by: ChesnoTech <263363000+ChesnoTech@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…boot recovery (#6) Handles connection loss, forced shutdowns, and duplicate instances: - Single-instance mutex: prevents two KeyGate instances running simultaneously - Persistent state file (C:\ProgramData\KeyGate\activation-state.json): writes state BEFORE each step, survives power cuts - Connection monitor: 2-second polling with auto-resume on reconnect - Invoke-WithRetry: wraps API calls with automatic retry + connection wait - Boot recovery scheduled task: on next boot, checks for pending state and reports activation result to server - Resume-FromState: on next launch, detects interrupted session and resumes from the correct phase (hw_submitted, key_installed, activated) Tested on Windows 11: - Mutex: correctly blocks second instance - State file: atomic write (tmp + move) survives interruption - Connection check: ping + HTTP health fallback works - Boot recovery: requires admin (CMD launcher always runs as admin) Co-authored-by: ChesnoTech <263363000+ChesnoTech@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
On fresh installs, create_admin.php created the admin user with custom_role_id = NULL. The ACL system uses custom_role_id to look up the role in acl_roles, so NULL meant zero permissions even for super_admin. Now queries acl_roles for the super_admin role ID and sets it during user creation. Found during full visual test of all 24 admin pages on a fresh Docker stack with clean database. Co-authored-by: ChesnoTech <263363000+ChesnoTech@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…RT (#8) TechniciansController tried to INSERT into preferred_server column which doesn't exist in the technicians table. Found during interactive CRUD testing on fresh Docker stack. Co-authored-by: ChesnoTech <263363000+ChesnoTech@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…#9) - handle_update_tech tried to UPDATE preferred_server column (doesn't exist) - Also accept 'id' as alias for 'tech_id' in update payload - Removes preferred_server validation that blocked updates Found during interactive CRUD testing on fresh Docker stack. Co-authored-by: ChesnoTech <263363000+ChesnoTech@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: ChesnoTech <263363000+ChesnoTech@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync main branch with latest develop changes.