Fix: set custom_role_id on fresh install admin creation#7
Merged
ChesnoTech merged 1 commit intodevelopfrom Mar 26, 2026
Merged
Conversation
On fresh installs, create_admin.php created the admin user with custom_role_id = NULL. The ACL system uses custom_role_id to look up the role in acl_roles, so NULL meant zero permissions even for super_admin. Now queries acl_roles for the super_admin role ID and sets it during user creation. Found during full visual test of all 24 admin pages on a fresh Docker stack with clean database. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom_role_id = NULLfalseacl_rolesfor thesuper_adminrole ID and sets itBranch Type
fix/— Bug fix (→ develop)Components Affected
Testing Checklist