feat: add Navbar component and update header and sections with IDs for smooth scrolling#7
Open
vedanta007 wants to merge 1 commit intoChessBase-India:mainfrom
Open
Conversation
…r smooth scrolling
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hadron43
requested changes
Feb 22, 2025
Member
There was a problem hiding this comment.
Thanks for PR! @vedanta007
@adxy I would recommend merging this to a different branch (say helpchess_redesign) and not main, as this breaks the overall theming scheme for the website.
We can later merge helpchess_redesign with main when all the components are redesigned.
Member
There was a problem hiding this comment.
Let's stick to using yarn as the package manager. In that case, we would not require package-lock.json file.
Member
There was a problem hiding this comment.
- Links should take to the parent container, and not the headings.
- The NavBar is not sticky
- In the design we have text, here we have the logo.
PR:
Design:
| "react-dom": "^18", | ||
| "styled-components": "^6.1.2" | ||
| "styled-components": "^6.1.2", | ||
| "yarn": "^1.22.22" |
| @@ -1,4 +1,5 @@ | |||
| import styled from "styled-components"; | |||
| import Navbar from "../Navbar"; | |||
Member
There was a problem hiding this comment.
- Use
@/components/Navbar. - Leave a line between library imports and custom component imports.
| <NavbarContainer> | ||
| <img src="/images/logo.png" alt="HELPCHESSFOUNDATION" style={{ width: '6.303rem', height: '2rem' }} /> | ||
| <NavLinks> | ||
| {routes.map((route) => ( |
Member
There was a problem hiding this comment.
Resolve warnings/errors in log:
Warning: Each child in a list should have a unique "key" prop.
Check the top-level render call using <pages__SectionDonate>. See https://reactjs.org/link/warning-keys for more information.
at DonateNowCard (webpack-internal:///./src/components/DonateNowCard.jsx:25:26)
at Home (webpack-internal:///./src/pages/index.jsx:153:80)
at div
at I (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:22679)
at div
at I (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:22679)
at Layout (webpack-internal:///./src/components/Layout/index.jsx:31:1)
at main
at exports.ThemeProvider (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:27623)
at App (webpack-internal:///./src/pages/_app.js:20:16)
at StyleRegistry (/home/hadron43/projects/helpchess/node_modules/styled-jsx/dist/index/index.js:449:36)
at eY (/home/hadron43/projects/helpchess/node_modules/next/dist/compiled/next-server/pages.runtime.dev.js:8:22559)
at eI (/home/hadron43/projects/helpchess/node_modules/next/dist/compiled/next-server/pages.runtime.dev.js:17:1760)
at eD (/home/hadron43/projects/helpchess/node_modules/next/dist/compiled/next-server/pages.runtime.dev.js:17:3083)
at div
at eQ (/home/hadron43/projects/helpchess/node_modules/next/dist/compiled/next-server/pages.runtime.dev.js:26:763)
styled-components: it looks like an unknown prop "secondary" is being sent through to the DOM, which will likely trigger a React console error. If you would like automatic filtering of unknown props, you can opt-into that behavior via `<StyleSheetManager shouldForwardProp={...}>` (connect an API like `@emotion/is-prop-valid`) or consider using transient props (`$` prefix for automatic filtering.)
Warning: Received `true` for a non-boolean attribute `secondary`.
If you want to write it to the DOM, pass a string instead: secondary="true" or secondary={value.toString()}.
at button
at I (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:22679)
at Button (webpack-internal:///./src/components/Button.jsx:24:19)
at a
at LinkComponent (webpack-internal:///./node_modules/next/dist/client/link.js:104:19)
at div
at I (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:22679)
at SupportOrgCard
at section
at I (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:22679)
at div
at I (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:22679)
at Home (webpack-internal:///./src/pages/index.jsx:153:80)
at div
at I (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:22679)
at div
at I (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:22679)
at Layout (webpack-internal:///./src/components/Layout/index.jsx:31:1)
at main
at exports.ThemeProvider (/home/hadron43/projects/helpchess/node_modules/styled-components/dist/styled-components.cjs.js:1:27623)
at App (webpack-internal:///./src/pages/_app.js:20:16)
at StyleRegistry (/home/hadron43/projects/helpchess/node_modules/styled-jsx/dist/index/index.js:449:36)
at eY (/home/hadron43/projects/helpchess/node_modules/next/dist/compiled/next-server/pages.runtime.dev.js:8:22559)
at eI (/home/hadron43/projects/helpchess/node_modules/next/dist/compiled/next-server/pages.runtime.dev.js:17:1760)
at eD (/home/hadron43/projects/helpchess/node_modules/next/dist/compiled/next-server/pages.runtime.dev.js:17:3083)
at div
at eQ (/home/hadron43/projects/helpchess/node_modules/next/dist/compiled/next-server/pages.runtime.dev.js:26:763)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.