Skip to content

Named unknowns in s_project_version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaydnTrigg merged 1 commit into from
Jan 23, 2026
Merged

Named unknowns in s_project_version #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/source/core/corelib/config/version.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,22 +274,22 @@ void version_set_project(s_project_version const * version)
" untracked");
}

if ( g_project_version.unknownC && *g_project_version.unknownC )
if ( g_project_version.build_date && *g_project_version.build_date )
{
csnzappendf(
version_globals.full_string,
NUMBEROF(version_globals.full_string),
" %s",
g_project_version.unknownC);
g_project_version.build_date);
}

if ( g_project_version.unknown10 && *g_project_version.unknown10 )
if ( g_project_version.build_time && *g_project_version.build_time )
{
csnzappendf(
version_globals.full_string,
NUMBEROF(version_globals.full_string),
" %s",
g_project_version.unknown10);
g_project_version.build_time);
}
};

Expand Down
4 changes: 2 additions & 2 deletions src/source/core/corelib/config/version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ struct s_project_version
char const* build_string;
char const* build_name;
long build_number;
char const* unknownC; // $todo what is this? it's used in version_set_project
char const* unknown10; // $todo what is this? it's used in version_set_project
char const* build_date;
char const* build_time;
char const* target_application;
char const* target_variant;
char const* target_configuration;
Expand Down
Loading