Skip to content

Fix CUDA/HIP build: use i32 typedef for arrival_state_offset #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robtaylor merged 1 commit into from
Mar 4, 2026
Merged

Fix CUDA/HIP build: use i32 typedef for arrival_state_offset #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions csrc/kernel_v1.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void simulate_v1_noninteractive_simple_scan_cuda(
usize num_cycles,
usize state_size,
u32 *states_noninteractive,
int arrival_state_offset
i32 arrival_state_offset
)
{
const u32 *timing_constraints = nullptr;
Expand Down Expand Up @@ -59,7 +59,7 @@ void simulate_v1_noninteractive_timed_cuda(
u32 *states_noninteractive,
const u32 *timing_constraints,
u8 *event_buffer,
int arrival_state_offset
i32 arrival_state_offset
)
{
void *arg_ptrs[12] = {
Expand Down
4 changes: 2 additions & 2 deletions csrc/kernel_v1.hip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ void simulate_v1_noninteractive_simple_scan_hip(
usize num_cycles,
usize state_size,
u32 *states_noninteractive,
int arrival_state_offset
i32 arrival_state_offset
)
{
validate_warp_size();
Expand Down Expand Up @@ -79,7 +79,7 @@ void simulate_v1_noninteractive_timed_hip(
u32 *states_noninteractive,
const u32 *timing_constraints,
u8 *event_buffer,
int arrival_state_offset
i32 arrival_state_offset
)
{
validate_warp_size();
Expand Down
4 changes: 2 additions & 2 deletions csrc/kernel_v1_impl.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ __device__ void simulate_block_v1(
u32 clock_period_ps,
EventBuffer *__restrict__ event_buffer,
u32 cycle_i,
int arrival_state_offset // offset in output_state for arrival data (0 = disabled)
i32 arrival_state_offset // offset in output_state for arrival data (0 = disabled)
)
{
int script_pi = 0;
Expand Down Expand Up @@ -574,7 +574,7 @@ __global__ void simulate_v1_noninteractive_simple_scan(
u32 *__restrict__ states_noninteractive,
const u32 *__restrict__ timing_constraints,
EventBuffer *__restrict__ event_buffer,
int arrival_state_offset
i32 arrival_state_offset
)
{
assert(num_blocks == gridDim.x);
Expand Down
Loading