Added UnifiedPush support by TastelessVoid · Pull Request #123 · Choochmeque/tauri-plugin-notifications

TastelessVoid · 2026-03-08T12:11:37Z

This implements UnifiedPush as backend for notifications, as some manufacturers, such as Fairphone don't have FCM/the required Google services for FCM installed and some users may prefer using a FOSS backend

codecov-commenter · 2026-03-08T12:15:59Z

Codecov Report

❌ Patch coverage is 33.33333% with 264 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.25%. Comparing base (9ba6c26) to head (90e5d49).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...app/tauri/notification/TauriNotificationManager.kt	0.00%	110 Missing ⚠️
.../java/app/tauri/notification/NotificationPlugin.kt	1.42%	69 Missing ⚠️
src/commands.rs	0.00%	36 Missing ⚠️
src/desktop.rs	0.00%	25 Missing ⚠️
...c/main/java/app/tauri/notification/Notification.kt	25.00%	15 Missing ⚠️
...i/notification/TauriUnifiedPushMessagingService.kt	93.22%	2 Missing and 2 partials ⚠️
.../main/java/app/tauri/notification/JSObjectUtils.kt	93.18%	0 Missing and 3 partials ⚠️
...java/app/tauri/notification/NotificationStorage.kt	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #123      +/-   ##
============================================
- Coverage     57.90%   56.25%   -1.66%     
- Complexity       65      111      +46     
============================================
  Files            29       31       +2     
  Lines          5096     5475     +379     
  Branches        232      303      +71     
============================================
+ Hits           2951     3080     +129     
- Misses         2111     2355     +244     
- Partials         34       40       +6

Flag	Coverage Δ
android	`29.79% <34.09%> (+1.62%)`	⬆️
ios	`78.60% <ø> (ø)`
javascript	`100.00% <100.00%> (ø)`
macos	`64.65% <100.00%> (-0.03%)`	⬇️
rust	`45.31% <7.57%> (-2.60%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR adds UnifiedPush as an optional backend for push notifications on Android, providing an alternative to FCM for devices without Google Play Services (e.g., Fairphone with de-Googled ROMs). It is gated behind a new unified-push Cargo feature flag that defaults to disabled.

Changes:

Adds 5 new Tauri commands (registerForUnifiedPush, unregisterFromUnifiedPush, getUnifiedPushDistributors, saveUnifiedPushDistributor, getUnifiedPushDistributor) implemented in Kotlin and exposed via the Rust/JS layer across all platforms (Android implementation, unsupported-platform stubs on iOS/macOS/desktop)
Adds Android receiver TauriUnifiedPushMessagingService to handle UnifiedPush lifecycle events (new endpoint, messages, unregistration, errors), plus a public UnifiedPushMessageHandler interface for custom message handling
Updates the build system, permissions, TypeScript API, and documentation to cover the new functionality

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
`src/models.rs`	Adds `UnifiedPushEndpointResponse`, `UnifiedPushDistributorsResponse`, and `UnifiedPushDistributorResponse` Rust structs (feature-gated)
`src/mobile.rs`	Implements the 5 new UnifiedPush methods on mobile, gated by `#[cfg(feature = "unified-push")]`
`src/macos.rs`	Adds stub methods that return "only supported on Android" errors
`src/desktop.rs`	Adds stub methods that return "not supported on desktop" errors
`src/commands.rs`	Adds Tauri command handlers for the 5 UnifiedPush operations
`src/lib.rs`	Registers the 5 new commands with the plugin
`build.rs`	Writes `enableUnifiedPush` to `android/build.properties` based on the Cargo feature flag
`android/build.gradle.kts`	Reads `enableUnifiedPush` property, adds `BuildConfig.ENABLE_UNIFIED_PUSH`, adds JitPack dependency
`android/settings.gradle`	Adds JitPack Maven repository
`android/src/main/AndroidManifest.xml`	Registers `TauriUnifiedPushMessagingService` as an exported broadcast receiver
`android/src/main/java/.../NotificationPlugin.kt`	Implements the 5 UP commands, permission handling, and callbacks; adds `getNotificationManager()` helper
`android/src/main/java/.../TauriUnifiedPushMessagingService.kt`	New `BroadcastReceiver` that dispatches UnifiedPush events to `NotificationPlugin` and runs the fallback notification path
`android/src/main/java/.../UnifiedPushMessageHandler.kt`	New public interface for custom message handling
`android/src/main/java/.../TauriNotificationManager.kt`	Adds `ic_notification` drawable and app icon as additional small-icon fallbacks
`guest-js/index.ts`	Adds TS types, function implementations, event listeners, and exports for the full UnifiedPush API
`permissions/default.toml`	Adds all 5 new `allow-*` permission identifiers to the default set
`permissions/schemas/schema.json`	Adds allow/deny schema entries for the 5 new commands
`permissions/autogenerated/reference.md`	Auto-generated permission reference updated
`permissions/autogenerated/commands/*.toml`	New per-command permission files for the 5 new commands
`Cargo.toml`	Adds `unified-push` feature declaration and updates crate description
`README.md`	Adds UnifiedPush setup, usage, and API reference documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/main/java/app/tauri/notification/TauriUnifiedPushMessagingService.kt

android/src/main/AndroidManifest.xml

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

android/settings.gradle

permissions/default.toml

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

android/build.gradle.kts

android/src/main/java/app/tauri/notification/TauriUnifiedPushMessagingService.kt

guest-js/index.ts

android/src/main/java/app/tauri/notification/TauriUnifiedPushMessagingService.kt

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/main/java/app/tauri/notification/TauriUnifiedPushMessagingService.kt

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

src/mobile.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…n.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…essagingService.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

android/src/main/java/app/tauri/notification/TauriUnifiedPushMessagingService.kt

android/src/main/java/app/tauri/notification/TauriNotificationManager.kt

android/build.gradle.kts

…ed-push-support

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/test/java/app/tauri/notification/NotificationPluginUnifiedPushTest.kt

android/src/test/java/app/tauri/notification/TauriUnifiedPushMessagingServiceTest.kt

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

guest-js/index.ts

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/main/java/app/tauri/notification/TauriUnifiedPushMessagingService.kt

android/src/test/java/app/tauri/notification/NotificationPluginUnifiedPushTest.kt

src/mobile.rs

android/src/main/java/app/tauri/notification/TauriUnifiedPushMessagingService.kt

…ndling

…r Sable

Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/test/java/app/tauri/notification/TauriUnifiedPushMessagingServiceTest.kt

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

guest-js/index.ts

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

README.md

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

…otifications and adress reviews

…cation storage tests for icon handling

Copilot

Pull request overview

Copilot reviewed 38 out of 38 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/main/java/app/tauri/notification/TauriNotificationManager.kt

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

android/src/main/java/app/tauri/notification/TauriUnifiedPushMessagingService.kt

…wnloading with enhanced security checks

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/main/java/app/tauri/notification/TauriNotificationManager.kt

android/src/main/java/app/tauri/notification/NotificationPlugin.kt

src/models.rs

… enhance security by stripping auth tokens from JSON

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-10T14:34:53Z

android/src/main/java/app/tauri/notification/TauriNotificationManager.kt

+  private val avatarExecutor: java.util.concurrent.ExecutorService = java.util.concurrent.Executors.newFixedThreadPool(4) { runnable ->
+    Thread(runnable).apply { isDaemon = true; name = "avatar-download" }


The TauriNotificationManager class creates a background thread-pool executor avatarExecutor on instantiation (line 53) for downloading avatar images, and exposes a destroy() method (line 233) to shut it down. However, destroy() is never called in NotificationPlugin — there is no override of any lifecycle method (e.g., onStop, onDestroy) that invokes manager.destroy(). This means the executor's threads will persist until the process terminates, and in long-running applications this could prevent proper resource cleanup.

Copilot · 2026-03-10T14:34:53Z

android/src/main/java/app/tauri/notification/TauriNotificationManager.kt

+          val raw = BitmapFactory.decodeStream(connection.inputStream)
+          connection.disconnect()
+          if (raw == null) return@Callable null
+          cropCircle(raw)


The submitAvatarDownload function downloads remote avatar images via HTTP connections and streams the response directly into BitmapFactory.decodeStream without any size limit check (line 188). A malicious or misconfigured server could return an extremely large image, leading to an OutOfMemoryError or significant memory pressure. Consider adding a Content-Length check before decoding, or use BitmapFactory.Options with inSampleSize / inJustDecodeBounds to limit the decoded image size.

Copilot · 2026-03-10T14:34:53Z

android/src/main/java/app/tauri/notification/TauriNotificationManager.kt

+  private fun prefetchAvatars(msgStyle: MessagingStyleConfig): Map<String, Bitmap?> {
+    val authToken = msgStyle.authToken
+    // Collect all unique URLs that need downloading
+    val urlsToDownload = mutableSetOf<String>()
+    msgStyle.user.iconUrl?.let { urlsToDownload.add(it) }
+    for (msg in msgStyle.messages) {
+      msg.sender?.iconUrl?.let { urlsToDownload.add(it) }
+    }
+    if (urlsToDownload.isEmpty()) return emptyMap()
+
+    // Submit all downloads in parallel
+    val futures = urlsToDownload.associateWith { url -> submitAvatarDownload(url, authToken) }
+
+    // Resolve all futures (total wait is ~10s max, not N×10s)
+    return futures.mapValues { (_, future) -> resolveAvatarFuture(future) }


The prefetchAvatars function calls resolveAvatarFuture (line 226) which blocks the calling thread for up to 10 seconds per batch. When this is called from buildNotification (which itself can be called on the main thread), this blocking network call can trigger an Android Application Not Responding (ANR) error. The notification-building path should either offload the entire operation to a background thread (e.g., using a coroutine or AsyncTask-style mechanism) before calling buildNotification, or the avatar download should happen entirely asynchronously and the notification should be updated once the download completes.

Copilot · 2026-03-10T14:34:54Z

src/commands.rs

+#[command]
+pub(crate) async fn unregister_from_unified_push<R: Runtime>(
+    _app: AppHandle<R>,
+    notification: State<'_, Notifications<R>>,
+) -> Result<()> {
+    notification.unregister_from_unified_push()
+}
+
+#[command]
+pub(crate) async fn get_unified_push_distributors<R: Runtime>(
+    _app: AppHandle<R>,
+    notification: State<'_, Notifications<R>>,
+) -> Result<serde_json::Value> {
+    notification.get_unified_push_distributors()
+}
+
+#[command]
+pub(crate) async fn save_unified_push_distributor<R: Runtime>(
+    _app: AppHandle<R>,
+    notification: State<'_, Notifications<R>>,
+    distributor: String,
+) -> Result<()> {
+    notification.save_unified_push_distributor(distributor)
+}
+
+#[command]
+pub(crate) async fn get_unified_push_distributor<R: Runtime>(
+    _app: AppHandle<R>,
+    notification: State<'_, Notifications<R>>,
+) -> Result<serde_json::Value> {
+    notification.get_unified_push_distributor()
+}


The unregister_from_unified_push Rust command handler (in src/commands.rs, line 64) is declared as async but calls a synchronous method notification.unregister_from_unified_push(). While this works correctly, for consistency with other synchronous commands in the file (like cancel, create_channel etc. which are non-async), the async keyword is unnecessary here and also for get_unified_push_distributors (line 72), save_unified_push_distributor (line 81), and get_unified_push_distributor (line 89). These commands don't need to be async since their implementations return synchronously.

Added UnifiedPush support

988ee33

Copilot AI review requested due to automatic review settings March 8, 2026 12:11

Copilot started reviewing on behalf of TastelessVoid March 8, 2026 12:11 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

TastelessVoid marked this pull request as draft March 8, 2026 12:37

TastelessVoid added 2 commits March 8, 2026 13:48

Move to UnifiedPush v3

f26e0fa

Minor fixes

15d3536

TastelessVoid marked this pull request as ready for review March 8, 2026 12:57

Copilot AI review requested due to automatic review settings March 8, 2026 12:57

Copilot started reviewing on behalf of TastelessVoid March 8, 2026 12:58 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Update src/mobile.rs

3fdf3e7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 8, 2026 13:08

Update android/src/main/java/app/tauri/notification/NotificationPlugi…

7bd435d

…n.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of TastelessVoid March 8, 2026 13:08 View session

TastelessVoid and others added 2 commits March 8, 2026 14:14

Update android/src/main/java/app/tauri/notification/TauriUnifiedPushM…

aa3db73

…essagingService.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update android/src/main/java/app/tauri/notification/TauriUnifiedPushM…

c9710f3

…essagingService.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Mar 8, 2026

View reviewed changes

TastelessVoid added 4 commits March 9, 2026 14:41

Added tests and locked UnifiedPush to Android

237ea4e

Added tests and locked UnifiedPush to Android

2753478

Merge remote-tracking branch 'origin/unified-push-support' into unifi…

4044ab7

…ed-push-support

Fixed compiling errors

21a1b0c

Copilot AI review requested due to automatic review settings March 9, 2026 13:56

Copilot started reviewing on behalf of TastelessVoid March 9, 2026 13:56 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

TastelessVoid added 2 commits March 9, 2026 15:12

Do not import UnifiedPush unconditionally or the CI/Unit test fail

61a4d83

Implement review suggestions

3d55514

Copilot AI review requested due to automatic review settings March 9, 2026 14:40

Copilot started reviewing on behalf of TastelessVoid March 9, 2026 14:41 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

TastelessVoid added 2 commits March 9, 2026 18:15

Added UnifiedPush related terms to cspell.json

b745963

Implement review suggestions from Copilot

17ecb04

TastelessVoid marked this pull request as draft March 9, 2026 17:28

TastelessVoid added 2 commits March 10, 2026 01:13

Add support for UnifiedPush temporary unavailability and VAPID key ha…

cd69721

…ndling

Added MessageStyling and other features that were TODO that I need fo…

9c0c1e0

…r Sable

Copilot AI review requested due to automatic review settings March 10, 2026 01:57

Copilot started reviewing on behalf of TastelessVoid March 10, 2026 01:58 View session

Added MessageStyling and other features that were TODO that I need fo…

bcfe750

…r Sable

Copilot AI reviewed Mar 10, 2026

View reviewed changes

TastelessVoid added 2 commits March 10, 2026 13:15

Add support for avatar images and authentication in messaging style n…

59fe15c

…otifications and adress reviews

Add avatar image downloading on a background thread and update notifi…

150e5b6

…cation storage tests for icon handling

Copilot AI review requested due to automatic review settings March 10, 2026 12:47

Copilot started reviewing on behalf of TastelessVoid March 10, 2026 12:48 View session

Fixed prettier issues

e48ecc5

Copilot AI reviewed Mar 10, 2026

View reviewed changes

TastelessVoid added 3 commits March 10, 2026 14:39

Refactor unified push permission handling and improve avatar image do…

ea3f3d8

…wnloading with enhanced security checks

Adjust codestyle to follow prettier to make CI happy

daa413d

Add logging for past scheduled notification time checks

c77ca0e

Copilot AI review requested due to automatic review settings March 10, 2026 13:56

Copilot started reviewing on behalf of TastelessVoid March 10, 2026 13:56 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

android/src/main/java/app/tauri/notification/TauriNotificationManager.kt Outdated Show resolved Hide resolved

android/src/main/java/app/tauri/notification/NotificationPlugin.kt Show resolved Hide resolved

src/models.rs Show resolved Hide resolved

Refactor avatar image downloading to prefetch avatars in parallel and…

90e5d49

… enhance security by stripping auth tokens from JSON

TastelessVoid marked this pull request as ready for review March 10, 2026 14:24

Copilot AI review requested due to automatic review settings March 10, 2026 14:24

Copilot started reviewing on behalf of TastelessVoid March 10, 2026 14:25 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

		private val avatarExecutor: java.util.concurrent.ExecutorService = java.util.concurrent.Executors.newFixedThreadPool(4) { runnable ->
		Thread(runnable).apply { isDaemon = true; name = "avatar-download" }

Uh oh!

Conversation

TastelessVoid commented Mar 8, 2026

Uh oh!

codecov-commenter commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

codecov-commenter commented Mar 8, 2026 •

edited

Loading