Proposal: change 1 second hold to hitting L/R or ZL/ZR buttons 3 times for song skip#1
Open
ColAlexsanders wants to merge 6 commits intoCinisSec:masterfrom
Open
Proposal: change 1 second hold to hitting L/R or ZL/ZR buttons 3 times for song skip#1ColAlexsanders wants to merge 6 commits intoCinisSec:masterfrom
ColAlexsanders wants to merge 6 commits intoCinisSec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that you were working on this issue too and made a pull request to the main project, so I decided to fork your version to address this matter.
While walking around with my 3ds ("New" 3ds regular size) in my pocket, I still had issues with song skips even with the 1 second hold (especially at the gym during sets). I changed it to 2 seconds, but unwanted skips would still occur on a common basis.
I then decided to try a three-time button press for the buttons, and that made song skips much less common, almost negating the issue in fact. I made it to where the buttons have to get pressed 3 times in under 500ms, but unwanted song skips still can happen I'm sure.
There is more info in the readme and main.c file for what I did exactly.