fix: date_created default value always set to server start time#777
Open
chunlampang wants to merge 2 commits intoCinnamon:mainfrom
Open
fix: date_created default value always set to server start time#777chunlampang wants to merge 2 commits intoCinnamon:mainfrom
chunlampang wants to merge 2 commits intoCinnamon:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect date_created defaults that were being evaluated at import/server start time, ensuring each new row gets the actual creation timestamp at insert time.
Changes:
- Update SQLAlchemy
date_createdcolumn defaults to use a callable (lambda) so they’re evaluated per-row. - Apply the fix consistently across both the Chroma migration script schema and the FileIndex dynamic table schemas.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/migrate/migrate_chroma_db.py | Makes date_created default evaluated at insert time for dynamically created Source tables in the migration script. |
| libs/ktem/ktem/index/file/index.py | Fixes date_created defaults for Source and FileGroup tables created by FileIndex._setup_resources(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
date_createddefault value is always set to server start timeType of change
Checklist