Report dynamic config continued workflow failure in run watch - #1650
Draft
gcirclest wants to merge 1 commit into
Draft
Report dynamic config continued workflow failure in run watch#1650gcirclest wants to merge 1 commit into
gcirclest wants to merge 1 commit into
Conversation
In dynamic config, when the continued workflow's config fails validation: - The error is recorded on the run itself (r.Errors); no continued workflow object is created - Even when a continued workflow IS created, it will have a non-succeeded outcome (e.g. "not_run") Previously, deriveDisplayStatus returned "succeeded" as soon as it found any workflow with outcome "succeeded" — the setup workflow — missing both cases above. Now: - Run-level errors are checked first and short-circuit to "errored", so a config validation error on the run is always surfaced - The last workflow's outcome is used for the final verdict (setup then continue, API returns in creation order), so a not_run continued workflow is not masked by the setup workflow's success - watchFinalResult includes any run-level error messages in the output so the user sees what went wrong, not just "run failed"
gcirclest
force-pushed
the
dynamic-config-report
branch
from
July 27, 2026 13:55
ea4b751 to
94f3988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deriveDisplayStatuspreviously returned"succeeded"as soon as it found any workflow withoutcome == "succeeded", so in a dynamic config pipeline the setup workflow's success masked the continued workflow's failurenot_runor other non-succeeded outcome on the continued workflow now correctly causesrun watchto exit 1Test plan
TestRunWatch_DynamicConfig_ContinuedWorkflowValidationError: setup workflowended/succeeded, continued workflowended/not_run→ exit code 1 and "failed" in output