[codex] Fix force overwrite sidecar contract#159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data/,GROUND_TRUTH.md, andOBSERVATION_MANIFEST.json.eforge generate --forcetransactional swap strict, now requiring staged data, ground truth, and observation manifest before replacing old output.Why
Prior fixes protected the swap by requiring staged
GROUND_TRUTH.md, but baseline-only generations could still skip ground truth entirely. That made successful generation fail during overwrite. The root contract is now explicit: successful generation always produces matched data and sidecars, so the swap can stay strict instead of accepting partial output.Validation
uv run pytest tests/unit/test_engine.py tests/unit/test_cli.py tests/unit/test_ground_truth.py tests/unit/test_observation_manifest.py --no-cov:112 passeduv run eforge validate-config: passed with0 errors, 0 warningsuv run ruff check .: passeduv run ruff format --check .: passeduv run pytest -v:3051 passed, 15 skippedSlow tests were not run.