Netconf custom verifier#102
Conversation
ThomasJRyan
left a comment
ThomasJRyan
left a comment
There was a problem hiding this comment.
Looks good overall. Just needs some housekeeping
| __contact__ = 'yang-python@cisco.com' | ||
| __copyright__ = 'Cisco Systems, Inc.' | ||
|
|
||
| from .count_verifier import CountVerifier |
There was a problem hiding this comment.
Was this removed intentionally? Seems strange to just get rid of it
| # Import base classes. For non pyats installation you can use class provided within this module | ||
| try: | ||
| from genie.libs.sdk.triggers.blitz.verifiers import GnmiDefaultVerifier | ||
| from genie.libs.sdk.triggers.blitz.verifiers import GnmiDefaultVerifier, NetconfDefaultVerifier |
There was a problem hiding this comment.
If this or GnmiDefaultVerifier failed to import, then the entire file will break since you won't be able to subclass NetconfDefaultVerifier. Is there something in the exception below you should be doing?
| from genie.libs.sdk.triggers.blitz.rpcverify import OptFields | ||
|
|
||
| @dataclass | ||
| class MyCustomReturns(OptFields): |
There was a problem hiding this comment.
I'd prefer something a bit more descriptive that MyCustomReturns. Honestly, I'd even just prefer CustomReturns over the current name
|
@KacperSzmitko would you please address Thomas's concerns? |
|
I did it in last commit |
|
@ThomasJRyan all the "housekeeping" has been addressed. Can you approve this? |
|
Thanks @ThomasJRyan . @omehrabi , @lsheikal , @yuekyang , need one more approver. |
3 participants
Added custom netconf verifier example that i accidentally deleted here