Skip to content

Update deploy script for setup.py migration#1026

Merged
anoto-moniz merged 2 commits intomainfrom
maintain/update-deploy
Mar 4, 2026
Merged

Update deploy script for setup.py migration#1026
anoto-moniz merged 2 commits intomainfrom
maintain/update-deploy

Conversation

@kroenlein
Copy link
Collaborator

Citrine Python PR

Description

Since the deploy script is not actually inherited from common-gh-actions, we need to manually update the local deploy script to update its build strategy.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@kroenlein kroenlein requested a review from a team as a code owner March 4, 2026 18:31
To keep things clean, let's force this release to 4.0.0
Copy link
Collaborator

@anoto-moniz anoto-moniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoto-moniz anoto-moniz merged commit 6575fc3 into main Mar 4, 2026
37 of 38 checks passed
@anoto-moniz anoto-moniz deleted the maintain/update-deploy branch March 4, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants