CMS 549: dev setup fixes#197
Open
barbara-prusiewicz wants to merge 9 commits intomasterfrom
Open
Conversation
Remove missing packages from bower install. Add legacy packages with missing packages and reference in gruntfile
6a0911a to
214a4f7
Compare
Serneum
reviewed
Jul 25, 2024
There was a problem hiding this comment.
This looks like it might do more than just update dev setup. I see changes in legacy_packages that I'd be hesitant to merge without releasing. What are these changes actually accomplishing?
It looks like this is just us copying code to make sure it's still available based on your PR body?
Author
|
legacy packages was created because the script build relied on packages that no longer exist in npm or github. Without this change, the script can not be built |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes to enable the project to be built locally.
CMS-549
Changes
Note on Known Test Failures:
When running tests locally (
grunt all or grunt test) the following errors are observed:ERROR: 'could not load TileJSON at http://a.tiles.mapbox.com/v4/adamjacobbecker.ja7plkah.json?access_token=pk.eyJ1IjoiYWRhbWphY29iYmVja2VyIiwiYSI6Im1SVEQtSm8ifQ.ZgEOSXsv9eLfGQ-9yAmtIg'This is a known issue with the map_marker field. Referenced mapbox tileset format is no longer supported. See CMS-51
Chrome Headless 126.0.6478.183 (Mac OS 10.15.7) adding and removing rows "before all" hook for "functions properly" FAILED Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.This error occurs frequently but not 100% of the time. Anecdotal observation is that it occurs much less frequently if the map_marker field is removed from test setups. Note that the error message is pointing to a "before all" hook that just creates a new instance of a FormRenderer object (using same test data as in other test cases). But issue may be inside test (where form pages need to be navigated).