[API] Validate agent endpoint URL format and block internal targets#5083
Closed
xyjk0511 wants to merge 1 commit into
Closed
[API] Validate agent endpoint URL format and block internal targets#5083xyjk0511 wants to merge 1 commit into
xyjk0511 wants to merge 1 commit into
Conversation
Constraint: Issue ClankerNation#187 requires endpoint URL validation with SSRF guardrails and bounded reachability checks. Rejected: Full URL validation middleware | touches broader API surface beyond minimal issue scope. Confidence: high Scope-risk: narrow Directive: Keep endpoint verification bounded to this route unless API-wide contract is explicitly requested. Tested: PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest -q api/tests/test_agents_endpoint_validation.py Not-tested: Full API integration through running FastAPI server
xyjk0511
force-pushed
the
c53d-187-endpoint-url-validate-v2
branch
from
be0fd0a to
a0e5b57
Compare
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request within 2 hours. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #187
/claim #187