fix(rpc): add timeout, batch limit, typed errors, and retry fixes#5166
Closed
lry3069-afk wants to merge 3 commits into
Closed
fix(rpc): add timeout, batch limit, typed errors, and retry fixes#5166lry3069-afk wants to merge 3 commits into
lry3069-afk wants to merge 3 commits into
Conversation
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request within 2 hours. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38
Summary
All 5 acceptance criteria addressed:
Timeout - AbortController with configurable imeoutMs (default 30s) on both call() and �atchCall(). Throws RpcTimeoutError on abort.
Batch size limit - BATCH_SIZE_LIMIT of 100 enforced before sending. Throws BatchSizeLimitError when exceeded.
Typed errors - 4 new error classes in errors.ts: RpcTimeoutError, RpcHttpError, RpcBatchError, BatchSizeLimitError. RPC error responses are type-checked (code/message validated).
Batch response matching - Responses matched by request id field instead of array position. Partial failures surface per-item errors via RpcBatchError.
Retry fixes - maxRetries capped at 5 (was Infinity). consecutiveFailures reset on success. Backoff exponent capped at 20 to prevent overflow. isRetryable() now matches 429/503 status codes.
Files changed
Testing