Attempt at additional_categories support #690
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at support for the additional_categories prototype field, which fixes #611 among others. I offer this in case it's helpful; adding this functionality required some design decisions which may well be better some other way instead.
Note that this code was substantially written by Claude/opencode. I have been using it successfully in my Seablock game, and I've reviewed it as well as I can. However, I am not all that conversant with either Lua or Factorio modding, so beware of the usual possible AI code issues.
Machine defaults are handled by constructing a new synthetic combined_category field, which encodes the entire set of categories a recipe is in, and setting the default on that field. Rather than duplicate machine entries across all possible values of combined_category, I leave the machines where they are, and index the defaults object by the combined_category string. This seems to work fine, but isn't quite analogous to the existing system for storing defaults.