fix(ingest): coerce YAML date/int tags to str in get_tags_from_frontmatter#31
Open
ruoxi001 wants to merge 1 commit into
Open
fix(ingest): coerce YAML date/int tags to str in get_tags_from_frontmatter#31ruoxi001 wants to merge 1 commit into
ruoxi001 wants to merge 1 commit into
Conversation
… docker-compose and setup.sh The worker container could not be configured to use an alternative embedding backend (Ollama, vLLM, etc.) because docker-compose.yml did not pass through EMBEDDING_API_BASE, EMBEDDING_MODEL, or EMBEDDING_API_KEY. The worker code (embedding.py) already reads these env vars — only the compose file was missing the plumbing. Changes: - docker-compose.yml: add 3 env vars to worker.environment with defaults preserving current OpenRouter/Qwen3 behavior - setup.sh: add_env for all 3 vars (consistency with EMBEDDING_DIMS) Closes ClaudioDrews#29
Code reviewFound 2 issues:
memory-os/docker/docker-compose.yml Lines 70 to 72 in 86816e4 Lines 331 to 333 in 86816e4
memory-os/docker/docker-compose.yml Lines 70 to 72 in 86816e4 Lines 331 to 333 in 86816e4 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
AttributeError: 'datetime.date' object has no attribute 'lower'when wiki frontmatter contains ISO date tags liketags: [foo, 2026-06-12].Fix
Coerce every non-None tag entry through
str(...)inget_tags_from_frontmatter()before using.lower(). Also handles int, float, and bool scalars for safety.Repro
-> worker raises
AttributeErrorAfter
Same frontmatter -> tags = ["important", "2026-06-12"]