All Feature's using Feature Flag Hook by HYDRO2070 · Pull Request #324 · ClearskyApp06/ClearskyUI

HYDRO2070 · 2025-03-16T20:40:01Z

No description provided.

vercel · 2025-03-16T20:40:06Z

@HYDRO2070 is attempting to deploy a commit to the thieflord06's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2025-03-16T20:44:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
clearsky-ui	Ready	Preview	Comment	Nov 17, 2025 4:59am

noahm

the majority of these flags are associated with specific queries the app makes, but as coded here, a disabled flag does not prevent the app from making the query. this defeats the whole point of having the flags in the first place.

HYDRO2070 · 2025-04-14T19:57:18Z

@noahm Done with the changes here. Please review it. (Name of the Variable are a bit long. I did it for Understanding Purpose.)
@thieflord06

noahm

This looks much better now. Very close to ready. There's one api call that got overlooked from last time, and two new places where you're now conditionally calling a hook. they should use the same pattern as the others where you can pass an enabled or skip parameter.

HYDRO2070 · 2025-04-15T19:11:22Z

@noahm @thieflord06
Done.

Regarding the label count: the API is fetching all the labels, not just calling it for the count. If we were to stop that call, the labels wouldn't be fetched at all—which we don’t want.

Signed-off-by: Shashank pandey <126805929+HYDRO2070@users.noreply.github.com>

noahm

You're totally right about the labels count, my apologies. (Seems like a completely pointless flag for us to have in that case) This looks good to go now!

thieflord06 · 2025-04-29T01:03:20Z

From testing it looks like the counts aren't behaving correctly when not enabled.

lists-blocking-count
blocked-by-count
blocking-count
lists-on-count
lists-blocked-by-count
lists-on-list-counts
starter-packs-in-count
labels-count

Labels-count is the only one I've been able to confirm is working as expected.

thieflord06 · 2025-06-19T15:37:16Z

@HYDRO2070 Any update on this?

HYDRO2070 · 2025-07-03T09:25:07Z

Done with the changes. Please check @thieflord06 @noahm

Copilot

Pull Request Overview

Most components and API hooks now respect feature flags for conditional data fetching and UI rendering.

Integrated useFeatureFlag in UI components to toggle stats, packs, lists, block panels, and account info features
Extended API hooks to accept feature-flag “enabled” parameters for conditional queries
Removed legacy commented checks and streamlined conditional rendering

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/landing/home-stats/home-stats-main.jsx	Added feature flag for total-users-wheel
src/detail-panels/packs/packs.jsx	Wrapped total count in `useFeatureFlag` guard
src/detail-panels/packs/packed.jsx	Introduced flag to control packs-in-count queries
src/detail-panels/lists/lists.jsx	Guarded list-count API and UI with feature flag
src/detail-panels/lists/list-view.jsx	Passed spam overlay flag to `ListViewEntry`
src/detail-panels/labeled/index.jsx	Wrapped labels-count header in feature-flag check
src/detail-panels/blocking/index.jsx	Conditional blocking count fetch and header
src/detail-panels/blocking-lists/blocking-lists-index.jsx	Feature-flag-guarded blocking-lists total
src/detail-panels/blocked-by/index.jsx	Guarded single block-by count with feature flag
src/detail-panels/blocked-by-lists/blocked-by-lists-index.jsx	Wrapped blocked-by-lists total in feature flag
src/detail-panels/block-panel-generic/block-panel-generic.jsx	Minor whitespace changes
src/detail-panels/account-header/account-header.jsx	Added flags for handle history and placement
src/detail-panels/account-header/account-extra-info.jsx	Wrapped description and handle history in flags
src/api/placement.js	Added `shoulduserPlacement` param to `usePlacement`
src/api/packs.js	Hook signatures updated for starter-packs totals
src/api/lists.js	Hook signature updated for list counts
src/api/handle-history.js	Hook signature updated for handle history
src/api/blocklist.js	Hook signatures updated for various blocklist totals

Comments suppressed due to low confidence (3)

src/detail-panels/packs/packs.jsx:27

[nitpick] The variable name shouldFetchstarterPacksMadeCount has inconsistent camelCase; consider shouldFetchStarterPacksMadeCount for readability.

  const shouldFetchstarterPacksMadeCount = useFeatureFlag('starter-packs-made-count');

src/api/placement.js:12

[nitpick] Parameter shoulduserPlacement should follow camelCase (shouldUserPlacement) to align with conventions.

export function usePlacement(handleOrDID,shoulduserPlacement) {

src/detail-panels/packs/packed.jsx:27

This assignment is split across two lines and will cause a syntax error. Combine into one statement, e.g.:
const shouldFetchStarterPacksInCount = useFeatureFlag('starter-packs-in-count');

  const shouldFetchstarterPacksInCount =

thieflord06 · 2025-09-20T14:30:57Z

handle-history and lists-on-list-counts is not working as expected @HYDRO2070

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Copilot

Pull Request Overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-17T05:06:13Z

+      header={({ count }) => (shouldFetchBlockingCount ? (<>
+        {localise(
+          `Blocking ${totalQuery.isLoading ? 'loading...' : count.toLocaleString()
+          }`,
+          {
+            uk: `Блокує ${totalQuery.isLoading ? 'loading...' : count.toLocaleString()
              }`,
-            }
-          )}
-        </>
+          }
+        )}
+      </>) : null


Inconsistent formatting: missing space after opening parenthesis and before closing parenthesis. The pattern should be consistent with other similar conditionals in the file, either shouldFetchBlockingCount ? (...) : null or add consistent spacing.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

thieflord06 · 2025-11-18T15:37:08Z

Total list of the scope of this ticket:

blocking-count
lists-blocked-by-search
blocked-by-count
starter-packs-in-search
starter-packs-made-search
handle-history
list-blocking-search
lists-on-list-counts
lists-on-count
labels-count
total-users-wheel
lists-blocked-by-users
lists-blocking-count
starter-packs-in-count
starter-packs-made-count
lists-blocked-by-count

Lists-on-count is currently associated with the counts of the lists, this needs to be changed to lists-on-list-counts and lists-on-count needs to be for the main total count on the lists tab. Also, restricted-lists-on-count needs to be renamed to restricted-lists-on-list-count.

HYDRO2070 · 2026-02-09T07:36:38Z

Starting ...

All Feature's using Feature Flag Hook

c38903a

vercel Bot deployed to Preview March 16, 2025 20:45 View deployment

thieflord06 requested review from noahm and thieflord06 March 16, 2025 21:33

noahm requested changes Mar 17, 2025

View reviewed changes

Optimize feature flag to skip unnecessary fetches

d21e848

vercel Bot deployed to Preview April 14, 2025 19:52 View deployment

noahm requested changes Apr 15, 2025

View reviewed changes

Comment thread src/detail-panels/account-header/account-header.jsx Outdated

Comment thread src/detail-panels/account-header/account-extra-info.jsx Outdated

Comment thread src/detail-panels/labeled/index.jsx

Remove Conditional Hook to Simplify Logic

859fe9f

vercel Bot deployed to Preview April 15, 2025 19:08 View deployment

Merge branch 'dev' into dev

3b8b6e2

Signed-off-by: Shashank pandey <126805929+HYDRO2070@users.noreply.github.com>

vercel Bot deployed to Preview April 15, 2025 19:25 View deployment

noahm approved these changes Apr 17, 2025

View reviewed changes

Merge branch 'ClearskyApp06:dev' into dev

52bba9d

vercel Bot deployed to Preview July 1, 2025 18:03 View deployment

Added the Conditional Rendering for False Flag

4d2a1c0

vercel Bot deployed to Preview July 3, 2025 09:22 View deployment

vercel Bot deployed to Preview July 3, 2025 09:26 View deployment

shashankpandey2070 force-pushed the dev branch from 0ae42a8 to 4d2a1c0 Compare July 3, 2025 09:35

thieflord06 requested review from Copilot and noahm July 3, 2025 16:39

Copilot AI reviewed Jul 3, 2025

View reviewed changes

Comment thread src/detail-panels/account-header/account-header.jsx Outdated

Comment thread src/detail-panels/labeled/index.jsx Outdated

thieflord06 enabled auto-merge July 3, 2025 16:43

thieflord06 linked an issue Nov 13, 2025 that may be closed by this pull request

Add feature flag framework to existing features #254

Open

thieflord06 and others added 12 commits November 16, 2025 22:54

Update src/landing/home-stats/home-stats-main.jsx

1e9a70a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/labeled/index.jsx

4575da5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/packs/packs.jsx

a72a5ab

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/packs/packed.jsx

2a08602

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/account-header/account-header.jsx

b99e6ce

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/packs/packed.jsx

a18684e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/api/handle-history.js

68e2a66

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/api/blocklist.js

1d1bf1d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/lists/lists.jsx

ffcedd7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/api/blocklist.js

50381ae

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/api/blocklist.js

a0bbe0a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/api/blocklist.js

00022c9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

vercel Bot deployed to Preview November 17, 2025 04:59 View deployment

thieflord06 requested a review from Copilot November 17, 2025 05:02

Copilot started reviewing on behalf of thieflord06 November 17, 2025 05:02 View session

Copilot finished reviewing on behalf of thieflord06 November 17, 2025 05:04

Copilot AI reviewed Nov 17, 2025

View reviewed changes

thieflord06 and others added 6 commits November 16, 2025 23:06

Update src/detail-panels/blocking-lists/blocking-lists-index.jsx

ad72164

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/account-header/account-header.jsx

3322977

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/account-header/account-header.jsx

584d477

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/blocking-lists/blocking-lists-index.jsx

e64d5ae

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/lists/lists.jsx

6f792c7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

Update src/detail-panels/blocked-by-lists/blocked-by-lists-index.jsx

516c3ff

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Justin <jburton6@aum.edu>

thieflord06 mentioned this pull request Nov 17, 2025

Add feature flag framework to existing features #254

Open

Copilot AI mentioned this pull request Nov 17, 2025

Add feature flag framework to route-level features #427

Closed

HYDRO2070 requested a review from noahm February 9, 2026 07:29

Uh oh!

Conversation

HYDRO2070 commented Mar 16, 2025

Uh oh!

vercel Bot commented Mar 16, 2025

Uh oh!

vercel Bot commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

noahm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HYDRO2070 commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

noahm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HYDRO2070 commented Apr 15, 2025

Uh oh!

noahm left a comment

Choose a reason for hiding this comment

Uh oh!

thieflord06 commented Apr 29, 2025

Uh oh!

thieflord06 commented Jun 19, 2025

Uh oh!

HYDRO2070 commented Jul 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

thieflord06 commented Sep 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thieflord06 commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HYDRO2070 commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel Bot commented Mar 16, 2025 •

edited

Loading

HYDRO2070 commented Apr 14, 2025 •

edited

Loading

thieflord06 commented Nov 18, 2025 •

edited

Loading