Block List Search Functionality #211 by rumanstheddy · Pull Request #435 · ClearskyApp06/ClearskyUI

rumanstheddy · 2026-01-14T18:01:46Z

No description provided.

…and UI updates - Implemented `runWithConcurrencyAndRetry` for async tasks with retry logic on 429 errors. - Added `fetchIsBlocking` and `fetchIsBlockedBy` functions for checking block status. - Enhanced `BlockPanelGeneric` to support searching for blocked accounts. - Updated CSS for search panel visibility. - Updated search functionality in `SearchAutoComplete` with filtering options. - Modified 'Blocked By' Panel and 'Blocking' Panel to pass `userHandle` and `isBlockingPanel` props.

…o feature/list-search-211

…points

vercel · 2026-01-14T18:01:50Z

@rumanstheddy is attempting to deploy a commit to the Clearsky Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2026-01-15T17:54:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clearsky-ui	Ready	Preview, Comment	Feb 6, 2026 2:56pm

vercel · 2026-01-15T17:54:38Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
clearsky-ui	Building	Preview, Comment	Jan 15, 2026 5:54pm

thieflord06 · 2026-02-04T22:08:51Z

@rumanstheddy working this now.

thieflord06 · 2026-02-04T22:25:47Z

@rumanstheddy List search bar isn't working correctly.

rumanstheddy · 2026-02-04T22:36:46Z

@thieflord06 Are the results not showing up?
Can you give me an example to test it with?

thieflord06 · 2026-02-04T22:38:27Z

When I click on the search icon the bar to type doesn't show up.

rumanstheddy · 2026-02-04T22:49:41Z

Could you please send a photo/video of what you see when you click the button?
This was recorded on Firefox. I verified the functionality on Chrome and Brave as well.

Screen.Recording.2026-02-04.174751.mp4

thieflord06 · 2026-02-04T23:04:01Z

@rumanstheddy I'm on chrome. It seems that the deploy is messed up somehow.

This is your latest deploy:
https://clearsky-b2668ml6g-clearsky-projects.vercel.app/

rumanstheddy · 2026-02-05T00:03:14Z

@thieflord06 yeah, even the home page looks messed up.

thieflord06 · 2026-02-05T00:27:43Z

@rumanstheddy can you push it again with a comment or something to see if that fixes it?

I tried redeploying and it didn't fix it.

rumanstheddy · 2026-02-05T00:45:35Z

@thieflord06 Sure. Just pushed a change.

Copilot

Pull request overview

This PR adds search functionality to the block lists (Blocking and Blocked By panels) in the Clearsky application. Users can now search for specific accounts within their block lists to quickly verify block relationships.

Changes:

Added customizable label prop and async filtering support to the SearchAutoComplete component
Implemented new API endpoints (fetchIsBlocking, fetchIsBlockedBy, and batch variants) with caching and retry logic for 429 errors
Integrated search UI into block panels with feature flag gating (blocking-searching)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
src/landing/search-autocomplete/search-autocomplete.jsx	Added `filterOptionsAsync` and `label` props to enable custom filtering and labels for the search component
src/detail-panels/blocking/index.jsx	Passed `userHandle` and `isBlockingPanel` props to enable search filtering in the blocking panel
src/detail-panels/blocked-by/index.jsx	Passed `userHandle` and `isBlockingPanel` props to enable search filtering in the blocked-by panel
src/detail-panels/block-panel-generic/block-panel-generic.jsx	Added search UI with toggle button, integrated SearchAutoComplete component, and implemented filtering logic
src/detail-panels/block-panel-generic/block-panel-generic.css	Added styles for search button, search container, and adjusted layout to accommodate search UI
src/api/blocklist.js	Implemented new API functions for checking block relationships with caching, concurrency control, and retry logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-06T15:06:06Z

+  // Attach cache keys to entries
+  const entriesWithCacheKey = entries.map((entry) => ({
+    ...entry,
+    _cacheKey: `${handle}:blockedby:${entry.shortHandle}`,


The cache key uses a simple string concatenation pattern (e.g., 'handle:blocking:otherHandle'). If handles contain colons, this could lead to cache key collisions. While unlikely for valid Bluesky handles, consider using a more robust key generation approach such as JSON.stringify or a dedicated cache key builder function to prevent potential collisions.

Suggested change

_cacheKey: `${handle}:blockedby:${entry.shortHandle}`,

_cacheKey: JSON.stringify(['blockedby', handle, entry.shortHandle]),

Copilot · 2026-02-06T15:06:07Z

+          '/' +
+            unwrapShortHandle(account.shortHandle) +
+            '/history/?q=' +
+            account.postID


The navigation URL construction for postID uses query parameter concatenation without proper encoding. If account.postID contains special characters, the URL could be malformed. Consider using URLSearchParams or encodeURIComponent to properly encode the postID value.

Suggested change

account.postID

encodeURIComponent(account.postID)

Copilot · 2026-02-06T15:06:07Z

+export async function fetchIsBlocking(handle1, handle2) {
+  const url = `blocklist-search-blocking/${unwrapShortHandle(
+    handle1
+  )}/${unwrapShortHandle(handle2)}`;
+  const res = await fetchClearskyApi('v1', url);
+  return res?.data ?? null;
+}


The fetchIsBlocking and fetchIsBlockedBy functions return null when the API response data is undefined, but the calling code in fetchIsBlockingMany/fetchIsBlockedByMany checks for valid data structure (lines 269-273, 299-304). If the API returns a successful response with an unexpected structure, it will be treated as undefined and filtered out. This is safe, but consider adding validation or logging to help identify API contract changes.

Copilot · 2026-02-06T15:06:07Z

+      // userHandle,
+      // isBlockingPanel,


These commented-out destructured props (userHandle, isBlockingPanel) are not used anywhere in the PanelHeader component. They were likely part of an earlier implementation where these values were passed directly to PanelHeader, but the final implementation passes filterOptionsAsync instead. These should be removed to avoid confusion.

Suggested change

// userHandle,

// isBlockingPanel,

Copilot · 2026-02-06T15:06:08Z

 *  onAccountSelected?: (account: Partial<AccountInfo & SearchMatch>) => void,
- *  onResolveAccount?: (text: string) => Promise<AccountInfo[]>
+ *  onResolveAccount?: (text: string) => Promise<AccountInfo[]>,
+ *  filterOptionsAsync?: (entry: any) => Promise<boolean>,


The type annotation for filterOptionsAsync indicates it should return Promise, but the implementation in block-panel-generic.jsx returns Promise, and the code at lines 197-199 expects an array. This is a type mismatch that could lead to confusion. The type annotation should be changed to reflect that this function receives an array and returns a filtered array: (entries: any[]) => Promise<any[]>.

Suggested change

* filterOptionsAsync?: (entry: any) => Promise<boolean>,

* filterOptionsAsync?: (entries: any[]) => Promise<any[]>,

Copilot · 2026-02-06T15:06:09Z

 import { TableChart, TableRows } from '@mui/icons-material';
 import SearchIcon from '@mui/icons-material/Search';
-import { Button, CircularProgress } from '@mui/material';
+import { Box, Button, CircularProgress, IconButton } from '@mui/material';


The Box import from '@mui/material' is added but never used in the component code. This unused import should be removed to keep the code clean.

Suggested change

import { Box, Button, CircularProgress, IconButton } from '@mui/material';

import { Button, CircularProgress, IconButton } from '@mui/material';

Copilot · 2026-02-06T15:06:09Z

- *  onResolveAccount?: (text: string) => Promise<AccountInfo[]>
+ *  onResolveAccount?: (text: string) => Promise<AccountInfo[]>,
+ *  filterOptionsAsync?: (entry: any) => Promise<boolean>,
+ *  label?: {en : string, localised: { [lang: string]: string }},


There's inconsistent spacing in the JSDoc type definition. The line has 'en : string' with a space before the colon, while the standard TypeScript/JavaScript convention is to have no space before the colon. This should be 'en: string' for consistency with coding standards.

Suggested change

* label?: {en : string, localised: { [lang: string]: string }},

* label?: {en: string, localised: { [lang: string]: string }},

Copilot · 2026-02-06T15:06:09Z

+  // const { accountFullHandle } = useAuth();
+


This commented-out code appears to be from an earlier implementation that was abandoned in favor of passing userHandle as a prop. Since it's not being used and there's no clear reason to keep it for future reference, it should be removed to keep the codebase clean.

Suggested change

// const { accountFullHandle } = useAuth();

Copilot · 2026-02-06T15:06:10Z

  text-align: right;
 }

+.MuiBox-root .css-r82bso {


The CSS selector '.MuiBox-root .css-r82bso' targets a Material-UI auto-generated class name, which is not stable across versions or builds. These hashed class names can change with Material-UI version updates or configuration changes, causing the style to stop working. Consider using a custom class name on the component or a more stable selector approach instead.

Suggested change

.MuiBox-root .css-r82bso {

.MuiBox-root > :first-child {

Copilot · 2026-02-06T15:06:10Z

+// Simple in-memory cache for endpoint results
+const _blocklistCache = new Map();


The in-memory cache uses a Map without any size limits or TTL (time-to-live). This can lead to unbounded memory growth over time as users search for many different accounts. Consider implementing cache eviction strategies such as LRU (Least Recently Used) or setting a maximum cache size, or adding a TTL to expire old entries.

rumanstheddy · 2026-02-06T18:56:11Z

@thieflord06 did it help?

thieflord06 · 2026-02-06T19:49:18Z

@rumanstheddy No change.

rumanstheddy · 2026-02-14T15:55:12Z

@thieflord06 is it fixed?
Want me to try another commit?

thieflord06 · 2026-04-22T04:04:48Z

@rumanstheddy When I run locally the home page looks normal.

rumanstheddy added 5 commits November 25, 2025 12:13

Merge branch 'dev' of https://github.com/ClearskyApp06/ClearskyUI int…

687a107

…o feature/list-search-211

Add React Query hooks for blocking and blocked status for testing end…

f4958c5

…points

refactor: code cleanup

e8096e5

style: update blocking panel layout

ee41696

rumanstheddy mentioned this pull request Jan 14, 2026

Re-introduce list search for blocked and blocked by #211

Open

vercel Bot deployed to Preview January 15, 2026 17:55 View deployment

comment out unused fetchIsBlocking and fetchIsBlockedBy functions

1ce5533

restore fetchIsBlocking and fetchIsBlockedBy

2f4a018

vercel Bot deployed to Preview February 6, 2026 14:56 View deployment

thieflord06 requested a review from Copilot February 6, 2026 14:59

Copilot started reviewing on behalf of thieflord06 February 6, 2026 14:59 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

	_cacheKey: `${handle}:blockedby:${entry.shortHandle}`,
	_cacheKey: JSON.stringify(['blockedby', handle, entry.shortHandle]),

	* filterOptionsAsync?: (entry: any) => Promise<boolean>,
	* filterOptionsAsync?: (entries: any[]) => Promise<any[]>,

	import { Box, Button, CircularProgress, IconButton } from '@mui/material';
	import { Button, CircularProgress, IconButton } from '@mui/material';

	* label?: {en : string, localised: { [lang: string]: string }},
	* label?: {en: string, localised: { [lang: string]: string }},

		// Simple in-memory cache for endpoint results
		const _blocklistCache = new Map();

Uh oh!

Conversation

rumanstheddy commented Jan 14, 2026

Uh oh!

vercel Bot commented Jan 14, 2026

Uh oh!

vercel Bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Jan 15, 2026

Uh oh!

thieflord06 commented Feb 4, 2026

Uh oh!

thieflord06 commented Feb 4, 2026

Uh oh!

rumanstheddy commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thieflord06 commented Feb 4, 2026

Uh oh!

rumanstheddy commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thieflord06 commented Feb 4, 2026

Uh oh!

rumanstheddy commented Feb 5, 2026

Uh oh!

thieflord06 commented Feb 5, 2026

Uh oh!

rumanstheddy commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

rumanstheddy commented Feb 6, 2026

Uh oh!

thieflord06 commented Feb 6, 2026

Uh oh!

rumanstheddy commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thieflord06 commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

vercel Bot commented Jan 15, 2026 •

edited

Loading

rumanstheddy commented Feb 4, 2026 •

edited

Loading

rumanstheddy commented Feb 4, 2026 •

edited

Loading

rumanstheddy commented Feb 5, 2026 •

edited

Loading

rumanstheddy commented Feb 14, 2026 •

edited

Loading