Skip to content

add center_longitude! at 0 test#194

Open
juliasloan25 wants to merge 1 commit into
mainfrom
js/center
Open

add center_longitude! at 0 test#194
juliasloan25 wants to merge 1 commit into
mainfrom
js/center

Conversation

@juliasloan25
Copy link
Copy Markdown
Member

Purpose

I encountered a problem when plotting with Makie, where plotting a variable with longitude in [0, 360] produces an improper plot (see MakieOrg/GeoMakie.jl#290). I wanted to use center_longitude! to recenter the longitude at 0 and produce longitude in [-180, 180], but calling center_longitude!(var, 0) maintains extrema(var.dims["long"]) == (0.0, 360.0), due to the use of circshift.

To-do

Content


  • I have read and checked the items on the review checklist.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.18%. Comparing base (28823aa) to head (54da413).
⚠️ Report is 134 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files          12       12           
  Lines        1209     1209           
=======================================
  Hits         1187     1187           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants