copy review skill into .agents

[alex-clickhouse]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR adds the existing ClickHouse PR review “skill” content under .agents/ (in addition to .claude/) so it can be consumed by other agent runtimes (e.g., chatgpt codex).

Changes:

• Add .agents/skills/review/SKILL.md containing the ClickHouse code review skill/template (copied from .claude/skills/review/SKILL.md).

[mshustov]

Have you created a copy of the file for testing?

[alex-clickhouse]

Yeah, gonna try to get the chatgpt codex github action for reviews working today, and I want it to use the skill.

[Codex]

The new .agents/skills/review/SKILL.md is an identical mirror of .claude/skills/review/SKILL.md so the Codex GitHub Action can consume the same review template; there isn’t an extra testing copy beyond that.

[alex-clickhouse]

@codex[agent] review

[Codex]

@codex[agent] review

1) Summary

Copies the existing review skill into .agents/skills/review/SKILL.md for Codex. Current duplication lacks a sync guard; risk of divergence between the two copies, so requesting a small safeguard before merge.

3) Findings

• ⚠️ Majors
  • [.agents/skills/review/SKILL.md:1] Duplicate of .claude/skills/review/SKILL.md with no declared source-of-truth or automated check, so the two copies can drift and yield inconsistent review guidance. Suggest adding an explicit sync note and a simple guard (e.g., CI equality check or generating one from the other) to keep them identical.

4) Tests & Evidence

• dotnet test --framework net9.0 --property WarningLevel=0 fails in this environment: integration tests target net10.0 only, and unit tests require CLICKHOUSE_CONNECTION env var. No additional tests needed for doc-only change.

5) ClickHouse C# Client Compliance Checklist

Check	Status	Notes
Protocol compatibility preserved?	N/A	Doc-only change
Multi-framework compatibility verified?	N/A	Doc-only change
Type system changes tested comprehensively?	N/A	Doc-only change
Async patterns correct (no sync-over-async)?	N/A	Doc-only change
PublicAPI/*.txt updated for API changes?	N/A	No API changes
Existing tests untouched (only additions)?	☑ Yes	No code changes
Connection string backward compatible?	N/A	Not applicable
Error messages clear and actionable?	N/A	Not applicable
Docs updated for user-facing changes?	☑ Yes	New skill copy
Thread safety reviewed?	N/A	Not applicable

6) Performance & Safety Notes

• None; documentation-only change.

7) User-Lens Review

• Without a sync guard, users may see divergent review templates depending on agent runtime, which is confusing for reviewers and PR authors.

8) Code Coverage

• Not applicable (no executable code changed).

9) Extras

• No changelog/release notes needed for doc-only addition.

Final Verdict

• Status: ⚠️ Request changes
• Minimum required actions: add a clear source-of-truth note and/or simple automation (e.g., CI diff check) to keep .agents/skills/review/SKILL.md in lockstep with .claude/skills/review/SKILL.md.