Fix crash in get_member_id() if client group is not initialized#4
Merged
azat merged 1 commit intoClickHouse/release-0.4.1from May 25, 2025
Merged
Fix crash in get_member_id() if client group is not initialized#4azat merged 1 commit intoClickHouse/release-0.4.1from
azat merged 1 commit intoClickHouse/release-0.4.1from
Conversation
Since in this case rd_kafka_memberid() return NULL, and std::string cannot be constructed from NULL [1]. [1]: https://github.com/llvm/llvm-project/blob/fe51d8ae5772626ef8237c33e0911695cf4f07db/libcxx/include/string#L1051-L1055
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
May 25, 2025
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
May 25, 2025
…om NULL It was likely an issue when the connection to broker had been failed. Refs: ClickHouse#80674 Refs: ClickHouse/cppkafka#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since in this case rd_kafka_memberid() return NULL, and std::string cannot be constructed from NULL 1.
Refs: ClickHouse/ClickHouse#80674 (comment)
Upstream: mfontanini#320