chore: avoid silent implicit type conversions#74
Merged
vadimskipin merged 1 commit intoJun 18, 2026
Merged
Conversation
follow up to ClickHouse#73 Added some compiler flags to avoid such silent converstions in the future. Played with different options and these combinations seems to be practical at the moment without much noise. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
vadimskipin
reviewed
Jun 17, 2026
vadimskipin
left a comment
vadimskipin
left a comment
Collaborator
There was a problem hiding this comment.
Personally I do not see any point of adding all this static_casts - the same data truncation with no checks...
vadimskipin
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #73
Added some compiler flags to avoid such silent converstions in the future. Played with different options and these combinations seems to be practical at the moment without much noise.