XCFramework Support

[npamidisf]

Adding changes to add support for building XCFrameworks. Also allowing users to pass custom flags via user options to be able support use cases like building swift frameworks with ABI Module stability and more needs

[npamidisf]

@amorde is this repo still accepting prs?

[AlexShubin]

Amazing work! Thank you @npamidisf! Would be also cool to have a parameter where I can put a list of frameworks that I want to build as XCFrameworks. In some cases, I can still want to use the old-school format for some old Objc libraries for example :)

[AlexShubin]

I would suggest a couple of additions to this function. Sometimes we can have references to the same dependencies through other dependencies (e.g. we can have RxSwift but also RxTest which requires RxSwift) which can lead to duplicates and errors then.

def build_xcframework(frameworks, build_dir, module_name)
  xcframework = "#{build_dir}/#{module_name}.xcframework"
  return if File.exist?(xcframework) 

  args = %W(-create-xcframework -output #{xcframework})

  frameworks.each do |framework|
    return unless File.exist?(framework) 
    args += %W(-framework #{framework})
  end

  Pod::Executable.execute_command 'xcodebuild', args, true
end

[npamidisf]

cool. thanks. will include

[Ricowere]

Hello guys!

Congrats to this pull request! Awesome work! 😍😍
I was testing this fork within my setup, and after adding the changes provided by Alex, it works perfectly given those changes also prevent some issues with aggregated targets, given some of them won't produce any frameworks and those checks will allow to detect that and skip the XCFramework generation.

I was wondering if you're planning to merge this soon, given that after going further on the setup within my project, I did flag some other major issues happening on the last steps (copy phase) from Rome. It would be great if I could create a pull request after those changes gets merged back in master. 🙏 🙏 🙏

Again, great work! 🌟 🌟 This is a major step forward into actively support Rome.

[Ricowere]

I've actually just found a pull request with such issue fixed here;

https://github.com/CocoaPods/Rome/pull/84/files#diff-1cf216328c39ad6fd0a36ecca66fb9870643fda2a42a9cd050bca52da8339edeR71

[AlexShubin]

Thanks for checking it out, @Ricowere! I'll add it as a suggestion. Also I don't think we're aware of merging plans, I'd gladly know it too :)

[npamidisf]

Amazing work! Thank you @npamidisf! Would be also cool to have a parameter where I can put a list of frameworks that I want to build as XCFrameworks. In some cases, I can still want to use the old-school format for some old Objc libraries for example :)

Good idea!!

[AlexShubin]

Suggested change

	def build_xcframework(frameworks, destination, module_name)
	args = %W(-create-xcframework -output #{destination}/#{module_name}.xcframework)
	frameworks.each do |framework|
	def build_xcframework(frameworks, build_dir, module_name)
	xcframework = "#{build_dir}/#{module_name}.xcframework"
	return if File.exist?(xcframework)
	args = %W(-create-xcframework -output #{xcframework})
	frameworks.each do |framework|
	return unless File.exist?(framework)

[orta]

Hi folks, we've not had anyone actively maintaining Rome for a while, do you want to take over and help out? I can help get you access etc

[temoki]

I just tried to build XCFramework using this branch and encountered the same problem as this URL.

xcframework does not contain internal frameworks
https://stackoverflow.com/questions/58805812/xcframework-does-not-contain-internal-frameworks

I was able to successfully build XCFramework by enabling the BUILD_LIBRARY_FOR_DISTRIBUTION flag in my podfile with the following statement.

plugin 'cocoapods-rome', { :pre_compile => Proc.new { |installer|
installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
        config.build_settings['BUILD_LIBRARY_FOR_DISTRIBUTION'] = 'YES'
    end
end

It would be nice if it could be built without the above description in the Podfile.

[temoki]

When I built the app by incorporating the XCFramework built with #90 (comment) into an Xcode project, I encountered the same problem as the following URL.

Xcode 11 XCFramework "... is not a member type of ..." error
https://developer.apple.com/forums/thread/123253

[temoki]

Finally, not adding the BUILD_LIBRARY_FOR_DISTRIBUTION flag and also adding the -allow-internal-distribution option when running -create-xcframework worked.

cocoapods-rome/post_install.rb#L70

#args = %W(-create-xcframework -output #{output})
args = %W(-create-xcframework -allow-internal-distribution -output #{output})

[xwal]

Hi @npamidisf @AlexShubin @Ricowere ,will this PR be merged?