Skip to content

Ticket 296#308

Open
naman0r wants to merge 8 commits into
mainfrom
ticket-296
Open

Ticket 296#308
naman0r wants to merge 8 commits into
mainfrom
ticket-296

Conversation

@naman0r
Copy link
Copy Markdown

@naman0r naman0r commented May 8, 2026

ℹ️ Issue

Closes <#296>

📝 Description

Replaces the placeholder grey circle in school emblem with the correct school's emblem, based on the school enum for each applicant.

Briefly list the changes made to the code:

  1. Created a RegEx function in the frontend that takes in an enum, converts it into the format that our school emblem pngs are, and finds it.
  2. Added a folder in the frontend with every school + their emblem image as png's.

✔️ Verification

Tested it out locally on computer.

🏕️ (Optional) Future Work / Notes

N/A

@cheangie cheangie marked this pull request as ready for review May 20, 2026 05:04
@SamNie2027
Copy link
Copy Markdown
Collaborator

Looks good code-wise but I would just request some image edits:

"Boston University" and "Boston University SOM DGMS physician assistant program" and "BU Mental Health Counseling and Behavioral Medicine Program"
image
This image is too low-resolution which is going to be noticeable especially since BU is such a big school

"Fisher College"
image
This image is pretty low-resolution

"Michigan State University"
image
Also pretty low-resolution

"Northeastern" "Northeastern Bouve College of Health Sciences"
image
Please use our circular emblem like the one below from our design:
image

"Salem State"
image
Also pretty low-resolution

Please change the default background of the school icon to be white but NOT when the enum is "Other" or "Does not apply"

@SamNie2027 SamNie2027 self-requested a review May 23, 2026 00:23
Copy link
Copy Markdown
Collaborator

@SamNie2027 SamNie2027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants