SSF 97 pantry management backend #76
Conversation
swarkewalia
changed the title
|
See slack comment |
swarkewalia
force-pushed
the
sk/SSF-97-pantry-management-backend
branch
2 times, most recently
from
313c63d to
2577fbe
Compare
swarkewalia
force-pushed
the
sk/SSF-97-pantry-management-backend
branch
from
2577fbe to
265bad6
Compare
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Make these initial changes, also see message I sent you.
| yarn-error.log | ||
| testem.log | ||
| /typings | ||
| .nx |
There was a problem hiding this comment.
Why is this here? Can we get rid of it?
| "@nestjs/core": "^10.0.2", | ||
| "@nestjs/passport": "^10.0.2", | ||
| "@nestjs/platform-express": "^10.0.2", | ||
| "@nestjs/swagger": "^7.4.2", |
There was a problem hiding this comment.
All of these dependency changes should not be here I don't think. Did you do anything in this ticket that required an update? I think you should just be able to merge the package.json from main into your branch and just use that instead.
| fulfilledAt: string; | ||
| } | ||
|
|
||
| export enum VolunteerType { |
There was a problem hiding this comment.
I think we should not have these changes. We just merged a PR in to migrate down to 1 volunteer type. This file should be unchanged. I would say also go through all of the other files to make sure that is not the case.
| pantries?: Pantry[]; | ||
| } | ||
|
|
||
| export interface UserDto { |
There was a problem hiding this comment.
This should not be deleted either I dont think.
| 'h1, h2, h3, h4, h5, h6': { | ||
| fontFamily: 'heading', | ||
| }, | ||
| body: { |
There was a problem hiding this comment.
Let's keep the old change here. We need this so our background for pages is actually white, not off-white
ℹ️ Issue 97
Closes 97
📝 Description
Added a new endpoint (getApprovedPantries) to return all information necessary for the pantry management frontend about pantries with 'approved' status - includes assigned volunteers.
Added a second new endpoint (updatePantryVolunteers) to overwrite the set of volunteers assigned to a pantry with a new set of volunteers.
Added a type file for pantries and included ApprovedPantryResponse and AssignedVolunteer types.
✔️ Verification
Tested both endpoints using curl. Made sure GET endpoint retrieved all approved pantries with assigned volunteers, and that the PUT endpoint overwrites volunteer assignments successfully.