Friend requests backend functionality by KLaw47 · Pull Request #10 · Code-Campfire/TeamUno_Python

KLaw47 · 2025-03-03T22:47:35Z

This is backend for the friend requests.

Create Friendship
automatically creates friendship with related status "PENDING"
POST
http://127.0.0.1:8000/api/friendships

Body:
{
"requested": {Id}
}

Accept Friendship
changes friendship status to "ACCEPTED" friendship status must be pending, must be logged in as the user that is being requested.
POST
http://127.0.0.1:8000/api/friendships/{id}/accept

Reject Friendship
changes friendship status to "REJECTED" friendship status must be pending,
must be logged in as the user that is being requested.
POST
http://127.0.0.1:8000/api/friendships/{id}/reject

Terminate Friendship
changes friendship status to "TERMINATED" friendship status must be accepted, either user may terminate.
POST
http://127.0.0.1:8000/api/friendships/{id}/terminate

No way to re-request friendship at this time.

X-CSRFToken must be in headers for all requests, matching the one generated on login.

api/views/friendship.py

+            )
+        except ValidationError as e:
+            return Response(
+                {"detail": str(e)},


To fix the problem, we need to ensure that detailed exception messages are not exposed to the end user. Instead, we should log the detailed error message on the server and return a generic error message to the user. This can be achieved by modifying the exception handling blocks to log the exception details and return a generic error message.

Specifically, we will:

Import the logging module to log the exception details.

Replace the detailed error message in the response with a generic message.

api/views/friendship.py

+            )
+        except Exception as e:
+            return Response(
+                {"detail": f"Failed to create friendship request: {str(e)}"},


To fix the problem, we need to ensure that detailed exception messages are not exposed to the end user. Instead, we should log the detailed error message on the server and return a generic error message to the user. This can be achieved by modifying the exception handling block to log the exception and return a generic error message.

Import the logging module to enable logging of exceptions.

Replace the detailed error message in the response with a generic error message.

Log the detailed exception message on the server.

api/views/friendship.py

+            serializer = self.get_serializer(friendship)
+            return Response(serializer.data)
+        except Exception as e:
+            return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)


To fix the problem, we need to ensure that detailed exception messages are not exposed to the user. Instead, we should log the detailed error message on the server and return a generic error message to the user. This can be achieved by modifying the exception handling in the accept, reject, and terminate methods.

Import the logging module to enable logging of detailed error messages.

Replace the current exception handling code to log the detailed error message and return a generic error message to the user.

api/views/friendship.py

+            serializer = self.get_serializer(friendship)
+            return Response(serializer.data)
+        except Exception as e:
+            return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)


To fix the problem, we need to ensure that detailed exception messages are not exposed to the user. Instead, we should log the detailed error message on the server and return a generic error message to the user. This can be achieved by modifying the exception handling blocks to log the exception and return a generic error message.

Import the logging module to enable logging of exceptions.

Replace the lines that return the exception message with lines that log the exception and return a generic error message.

api/views/friendship.py

+            serializer = self.get_serializer(friendship)
+            return Response(serializer.data)
+        except Exception as e:
+            return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)


To fix the problem, we need to ensure that detailed exception messages are not exposed to the end user. Instead, we should log the detailed error message on the server and return a generic error message to the user. This can be achieved by modifying the exception handling code to log the exception and return a generic error message.

Import the logging module to enable logging of exceptions.

Replace the lines that return the exception message with code that logs the exception and returns a generic error message.

willyummaclean and others added 7 commits January 30, 2025 15:29

view and model update

bf0863d

poetry installed with toml file

bf4abc1

working on it

6432b61

testing

eedaf69

merged main conflicts

b3ba417

tested endpoints, added status to readonly so its automatically set

48df740

added permission classes to friend requests

45524a9

github-advanced-security bot found potential problems Mar 3, 2025

View reviewed changes

@@ -9,3 +9,3 @@
             from rest_framework import serializers, permissions
+            import logging
             class FriendshipSerializer(serializers.ModelSerializer):
@@ -77,4 +77,5 @@
                     except ValidationError as e:
+                        logging.error(f"Validation error: {str(e)}")
                         return Response(
-                            {"detail": str(e)},
+                            {"detail": "Invalid input data"},
                             status=status.HTTP_400_BAD_REQUEST
@@ -87,4 +88,5 @@
                     except Exception as e:
+                        logging.error(f"Unexpected error: {str(e)}")
                         return Response(
-                            {"detail": f"Failed to create friendship request: {str(e)}"},
+                            {"detail": "Failed to create friendship request"},
                             status=status.HTTP_500_INTERNAL_SERVER_ERROR

@@ -9,2 +9,5 @@
             from rest_framework import serializers, permissions
+            import logging
+            logger = logging.getLogger(__name__)
@@ -87,4 +90,5 @@
                     except Exception as e:
+                        logger.error("Failed to create friendship request", exc_info=True)
                         return Response(
-                            {"detail": f"Failed to create friendship request: {str(e)}"},
+                            {"detail": "An internal error has occurred."},
                             status=status.HTTP_500_INTERNAL_SERVER_ERROR

@@ -9,3 +9,3 @@
             from rest_framework import serializers, permissions
+            import logging
             class FriendshipSerializer(serializers.ModelSerializer):
@@ -130,3 +130,4 @@
                     except Exception as e:
-                        return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+                        logging.error("Error accepting friendship request: %s", str(e))
+                        return Response({"detail": "An internal error has occurred."}, status=status.HTTP_400_BAD_REQUEST)
@@ -149,3 +150,4 @@
                     except Exception as e:
-                        return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+                        logging.error("Error rejecting friendship request: %s", str(e))
+                        return Response({"detail": "An internal error has occurred."}, status=status.HTTP_400_BAD_REQUEST)
@@ -168,2 +170,3 @@
                     except Exception as e:
-                        return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+                        logging.error("Error terminating friendship: %s", str(e))
+                        return Response({"detail": "An internal error has occurred."}, status=status.HTTP_400_BAD_REQUEST)

@@ -9,2 +9,3 @@
             from rest_framework import serializers, permissions
+            import logging
@@ -130,3 +131,4 @@
                     except Exception as e:
-                        return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+                        logging.error("Error accepting friendship request: %s", str(e))
+                        return Response({"detail": "An internal error has occurred."}, status=status.HTTP_400_BAD_REQUEST)
@@ -149,3 +151,4 @@
                     except Exception as e:
-                        return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+                        logging.error("Error rejecting friendship request: %s", str(e))
+                        return Response({"detail": "An internal error has occurred."}, status=status.HTTP_400_BAD_REQUEST)
@@ -168,2 +171,3 @@
                     except Exception as e:
-                        return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+                        logging.error("Error terminating friendship: %s", str(e))
+                        return Response({"detail": "An internal error has occurred."}, status=status.HTTP_400_BAD_REQUEST)

@@ -9,2 +9,3 @@
             from rest_framework import serializers, permissions
+            import logging
@@ -130,3 +131,4 @@
                     except Exception as e:
-                        return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+                        logging.error("Error accepting friendship request: %s", str(e))
+                        return Response({"detail": "An internal error has occurred."}, status=status.HTTP_400_BAD_REQUEST)
@@ -149,3 +151,4 @@
                     except Exception as e:
-                        return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+                        logging.error("Error rejecting friendship request: %s", str(e))
+                        return Response({"detail": "An internal error has occurred."}, status=status.HTTP_400_BAD_REQUEST)
@@ -168,2 +171,3 @@
                     except Exception as e:
-                        return Response({"detail": str(e)}, status=status.HTTP_400_BAD_REQUEST)
+                        logging.error("Error terminating friendship: %s", str(e))
+                        return Response({"detail": "An internal error has occurred."}, status=status.HTTP_400_BAD_REQUEST)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Friend requests backend functionality#10

Friend requests backend functionality#10
KLaw47 wants to merge 7 commits intomainfrom
friend-requests

KLaw47 commented Mar 3, 2025 •

edited

Loading

Uh oh!

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Check warning

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

KLaw47 commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check warning

Uh oh!

Copilot Autofix

Check warning

Uh oh!

Copilot Autofix

Check warning

Uh oh!

Copilot Autofix

Check warning

Uh oh!

Copilot Autofix

Check warning

Uh oh!

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KLaw47 commented Mar 3, 2025 •

edited

Loading