Space: Add get_children#61
Merged
Merged
Conversation
# Conflicts: # matrix/bot.py # matrix/space.py # tests/test_bot.py
PenguinBoi12
force-pushed
the
feature/space-get_children
branch
from
3e197f2 to
2b449b0
Compare
PenguinBoi12
force-pushed
the
feature/space-get_children
branch
from
f98caaf to
83fb8de
Compare
chrisdedman
approved these changes
Jun 29, 2026
chrisdedman
left a comment
chrisdedman
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Do you think we should have an example in /examples/ ?
Contributor
Author
I don't think so, instead I'll write some doc about all that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
get_childrento the newSpaceclass.get_childrenretrieves all children and converts them intoRoomorSpaceinstance through themake_roomfactory. Bot also leverages the newmake_roomfactory.The PR includes a module-level registry in
room.pyto centralize the creation logic of Room and Space. This avoids duplicating the instantiation logic while keepingRoomandSpacecleanly separated. The registry uses__init_subclass__so subclasses self-register, avoiding a standalone factory module that would have added circular imports.