feat: add get_members method to Room#74
Conversation
PenguinBoi12
left a comment
There was a problem hiding this comment.
Nice, clean addition, docstring and tests are solid, and the wrapper matches the existing patterns. Well done. Apart from the docstring format, it's a great PR.
|
Fixed the docstring indentation to match the rest of the codebase's style. Thanks for the catch! |
Hi, the docstring still seems incorrectly formatted. Make sure your editor isn't applying a formatting on it before you push. @AchieverSana |
|
Ah, turns out it wasn't just the docstring — the whole method was mis-indented. Fixed and double-checked with black this time. Pushed in b5c95f0; thanks for catching it! |
|
Hey, this should be ready to merge now — just needs the workflow approvals if you get a chance! |
Adds a
get_membersmethod to theRoomclass that fetches the list of currently joined user IDs by querying the Matrix server directly viaAsyncClient.joined_members.Closes #70