Skip to content

feat: add get_members method to Room#74

Merged
PenguinBoi12 merged 5 commits into
Code-Society-Lab:mainfrom
AchieverSana:add-get-members
Jul 2, 2026
Merged

feat: add get_members method to Room#74
PenguinBoi12 merged 5 commits into
Code-Society-Lab:mainfrom
AchieverSana:add-get-members

Conversation

@AchieverSana

Copy link
Copy Markdown
Contributor

Adds a get_members method to the Room class that fetches the list of currently joined user IDs by querying the Matrix server directly via AsyncClient.joined_members.

Closes #70

@PenguinBoi12 PenguinBoi12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clean addition, docstring and tests are solid, and the wrapper matches the existing patterns. Well done. Apart from the docstring format, it's a great PR.

Comment thread matrix/room.py
@AchieverSana

Copy link
Copy Markdown
Contributor Author

Fixed the docstring indentation to match the rest of the codebase's style. Thanks for the catch!

@AchieverSana AchieverSana requested a review from PenguinBoi12 July 1, 2026 06:02
@PenguinBoi12

PenguinBoi12 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Fixed the docstring indentation to match the rest of the codebase's style. Thanks for the catch!

Hi, the docstring still seems incorrectly formatted. Make sure your editor isn't applying a formatting on it before you push. @AchieverSana

@AchieverSana

AchieverSana commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Ah, turns out it wasn't just the docstring — the whole method was mis-indented. Fixed and double-checked with black this time. Pushed in b5c95f0; thanks for catching it!

@PenguinBoi12 PenguinBoi12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦭

@AchieverSana

Copy link
Copy Markdown
Contributor Author

Hey, this should be ready to merge now — just needs the workflow approvals if you get a chance!

@PenguinBoi12 PenguinBoi12 merged commit 43be602 into Code-Society-Lab:main Jul 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Room: Add get_members method

2 participants