-
Notifications
You must be signed in to change notification settings - Fork 5
Implement list_jobs method in scheduler #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shouryaverma19
wants to merge
11
commits into
Code-Society-Lab:main
Choose a base branch
from
Shouryaverma19:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−0
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
36731e1
Implement list_jobs method in scheduler
Shouryaverma19 d89ef60
Add tests for Scheduler's list_jobs method
Shouryaverma19 ab02f15
Update test_scheduler.py
Shouryaverma19 808a4e0
Update test_scheduler.py
Shouryaverma19 0c5a3a5
Merge branch 'main' into patch-1
chrisdedman b4f779a
style: format with double spacing for black
Shouryaverma19 dde8009
Merge branch 'main' into patch-1
Shouryaverma19 eac162c
Remove duplicate list_jobs method
Shouryaverma19 26cd188
Update test_scheduler.py
Shouryaverma19 8ccf22a
Implement unschedule method for job removal
Shouryaverma19 d57f42d
Enhance scheduler tests with job management cases
Shouryaverma19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import pytest | ||
| from matrixpy.scheduler import Scheduler | ||
|
|
||
|
|
||
| def sample_task() -> None: | ||
| pass | ||
|
|
||
|
PenguinBoi12 marked this conversation as resolved.
|
||
|
|
||
| def test_scheduler_job_management() -> None: | ||
| scheduler = Scheduler() | ||
|
|
||
| # 1. Verify list_jobs returns an empty list on initialization | ||
| assert scheduler.list_jobs() == [] | ||
|
|
||
| # 2. Verify list_jobs returns the correct name after scheduling | ||
| scheduler.schedule("*/5 * * * *", sample_task) | ||
| assert scheduler.list_jobs() == ["sample_task"] | ||
|
|
||
| # 3. Verify unschedule cleanly removes the job from the system | ||
| scheduler.unschedule("sample_task") | ||
| assert scheduler.list_jobs() == [] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the test is not an appropriate way to fix the issue. Now the feature isn't fully tested.