-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Add pin and unpin methods to Message class #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nik1062
wants to merge
6
commits into
Code-Society-Lab:main
Choose a base branch
from
nik1062:issue-67-pin-unpin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
97b30fa
feat: Add pin and unpin methods to Message class
nik1062 faf005c
refactor: address review comments for pin/unpin methods
nik1062 fe4f108
nit: use .get() with default and fix formatting
nik1062 c5000bf
Merge branch 'main' into issue-67-pin-unpin
PenguinBoi12 85321cb
Merge upstream/main: resolve conflicts in message.py and test_message.py
nik1062 d38b6e6
Refactor pin/unpin methods to use matrix_call for error handling
nik1062 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I did some research and testing and this won't work. matrix does not return "404" as status code, it returns a "M_NOT_FOUND". So you need to change
if response.status_code == "M_NOT_FOUND":The reason why your tests worked is because you mocked the response; it was a false positive.
GET /rooms/{roomId}/state/{eventType}/{stateKey}matrix-org/matrix-spec—data/api/client-server/rooms.yamlmatrix-nio/matrix-nio—src/nio/responses.py,ErrorResponseErrorResponse.from_dict