Refactor Matrix API errors handling#85
Merged
Merged
Conversation
chrisdedman
approved these changes
Jul 2, 2026
chrisdedman
left a comment
Contributor
There was a problem hiding this comment.
Thank you. Great pattern for better errors handling. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matrix-nio's
AsyncClientreturnsErrorResponseinstead of raising when an request error happens. Our currenttry/exceptpattern only caught lower level exception exceptions, so a rejected call either silently succeeded or raises a confusingAttributeErrormessage instead of the real server error. To fix the issue and handle errors correctly, a wrapper calledmatrix_call()was added to wrap everyAsyncClientcalls and translates all type of error into aMatrixErrorwith the actual API error message.Additionally to adding the wrapper, all places making calls using the old pattern were refactored to use
matrix_callinstead.Example