Add configurable name format preferences for user display and sorting

Gibbon.Git.Server.Tests/Models/UserModelTest.cs

@@ -1,4 +1,5 @@
-using Gibbon.Git.Server.Models;
+using Gibbon.Git.Server.Data.Entities;
+using Gibbon.Git.Server.Models;
 
 namespace Gibbon.Git.Server.Tests.Models;
 
@@ -27,4 +28,100 @@ public void SortNameFormation()
         Assert.AreEqual("Smith", new UserModel { GivenName = "", Surname = "Smith" }.SortName);
         Assert.AreEqual("JohnSmith", new UserModel { Username = "JohnSmith" }.SortName);
     }
+
+    [TestMethod]
+    public void DisplayNameFormation_FirstLast()
+    {
+        var user = new UserModel { GivenName = "John", Surname = "Smith" };
+        Assert.AreEqual("John Smith", user.GetDisplayName(NameFormat.FirstLast));
+
+        var userOnlyGiven = new UserModel { GivenName = "John", Surname = null };
+        Assert.AreEqual("John", userOnlyGiven.GetDisplayName(NameFormat.FirstLast));
+
+        var userOnlySurname = new UserModel { GivenName = null, Surname = "Smith" };
+        Assert.AreEqual("Smith", userOnlySurname.GetDisplayName(NameFormat.FirstLast));
+
+        var userNoNames = new UserModel { Username = "JohnSmith" };
+        Assert.AreEqual("JohnSmith", userNoNames.GetDisplayName(NameFormat.FirstLast));
+    }
+
+    [TestMethod]
+    public void DisplayNameFormation_LastCommaFirst()
+    {
+        var user = new UserModel { GivenName = "John", Surname = "Smith" };
+        Assert.AreEqual("Smith, John", user.GetDisplayName(NameFormat.LastCommaFirst));
+
+        var userOnlyGiven = new UserModel { GivenName = "John", Surname = null };
+        Assert.AreEqual("John", userOnlyGiven.GetDisplayName(NameFormat.LastCommaFirst));
+
+        var userOnlySurname = new UserModel { GivenName = null, Surname = "Smith" };
+        Assert.AreEqual("Smith", userOnlySurname.GetDisplayName(NameFormat.LastCommaFirst));
+
+        var userNoNames = new UserModel { Username = "JohnSmith" };
+        Assert.AreEqual("JohnSmith", userNoNames.GetDisplayName(NameFormat.LastCommaFirst));
+    }
+
+    [TestMethod]
+    public void DisplayNameFormation_LastFirst()
+    {
+        var user = new UserModel { GivenName = "John", Surname = "Smith" };
+        Assert.AreEqual("Smith John", user.GetDisplayName(NameFormat.LastFirst));
+
+        var userOnlyGiven = new UserModel { GivenName = "John", Surname = null };
+        Assert.AreEqual("John", userOnlyGiven.GetDisplayName(NameFormat.LastFirst));
+
+        var userOnlySurname = new UserModel { GivenName = null, Surname = "Smith" };
+        Assert.AreEqual("Smith", userOnlySurname.GetDisplayName(NameFormat.LastFirst));
+
+        var userNoNames = new UserModel { Username = "JohnSmith" };
+        Assert.AreEqual("JohnSmith", userNoNames.GetDisplayName(NameFormat.LastFirst));
+    }
+
+    [TestMethod]
+    public void SortNameFormation_FirstLast()
+    {
+        var user = new UserModel { GivenName = "John", Surname = "Smith" };
+        Assert.AreEqual("JohnSmith", user.GetSortName(NameFormat.FirstLast));
+
+        var userOnlyGiven = new UserModel { GivenName = "John", Surname = null };
+        Assert.AreEqual("John", userOnlyGiven.GetSortName(NameFormat.FirstLast));
+
+        var userOnlySurname = new UserModel { GivenName = null, Surname = "Smith" };
+        Assert.AreEqual("Smith", userOnlySurname.GetSortName(NameFormat.FirstLast));
+
+        var userNoNames = new UserModel { Username = "JohnSmith" };
+        Assert.AreEqual("JohnSmith", userNoNames.GetSortName(NameFormat.FirstLast));
+    }
+
+    [TestMethod]
+    public void SortNameFormation_LastCommaFirst()
+    {
+        var user = new UserModel { GivenName = "John", Surname = "Smith" };
+        Assert.AreEqual("SmithJohn", user.GetSortName(NameFormat.LastCommaFirst));
+
+        var userOnlyGiven = new UserModel { GivenName = "John", Surname = null };
+        Assert.AreEqual("John", userOnlyGiven.GetSortName(NameFormat.LastCommaFirst));
+
+        var userOnlySurname = new UserModel { GivenName = null, Surname = "Smith" };
+        Assert.AreEqual("Smith", userOnlySurname.GetSortName(NameFormat.LastCommaFirst));
+
+        var userNoNames = new UserModel { Username = "JohnSmith" };
+        Assert.AreEqual("JohnSmith", userNoNames.GetSortName(NameFormat.LastCommaFirst));
+    }
+
+    [TestMethod]
+    public void SortNameFormation_LastFirst()
+    {
+        var user = new UserModel { GivenName = "John", Surname = "Smith" };
+        Assert.AreEqual("SmithJohn", user.GetSortName(NameFormat.LastFirst));
+
+        var userOnlyGiven = new UserModel { GivenName = "John", Surname = null };
+        Assert.AreEqual("John", userOnlyGiven.GetSortName(NameFormat.LastFirst));
+
+        var userOnlySurname = new UserModel { GivenName = null, Surname = "Smith" };
+        Assert.AreEqual("Smith", userOnlySurname.GetSortName(NameFormat.LastFirst));
+
+        var userNoNames = new UserModel { Username = "JohnSmith" };
+        Assert.AreEqual("JohnSmith", userNoNames.GetSortName(NameFormat.LastFirst));
+    }
 }

Gibbon.Git.Server/App_Resources/Resources.resx

@@ -700,6 +700,21 @@
   <data name="Settings_Global_DefaultLanguage_Hint" xml:space="preserve">
     <value>Language set by default in the application.</value>
   </data>
+  <data name="Settings_NameFormat" xml:space="preserve">
+    <value>Name Format</value>
+  </data>
+  <data name="Settings_NameFormat_Hint" xml:space="preserve">
+    <value>Choose how names are displayed throughout the application.</value>
+  </data>
+  <data name="Settings_NameFormat_FirstLast" xml:space="preserve">
+    <value>First Last (e.g., John Smith)</value>
+  </data>
+  <data name="Settings_NameFormat_LastCommaFirst" xml:space="preserve">
+    <value>Last, First (e.g., Smith, John)</value>
+  </data>
+  <data name="Settings_NameFormat_LastFirst" xml:space="preserve">
+    <value>Last First (e.g., Smith John)</value>
+  </data>
   <data name="Repository_Detail_Status" xml:space="preserve">
     <value>Status</value>
   </data>

Gibbon.Git.Server/Configuration/UserSettings.cs

@@ -1,7 +1,9 @@
-namespace Gibbon.Git.Server.Configuration;
+using Gibbon.Git.Server.Data.Entities;
+
+namespace Gibbon.Git.Server.Configuration;
 
 public sealed class UserSettings
 {
     public string PreferredLanguage { get; set; }
-
+    public NameFormat PreferredNameFormat { get; set; }
 }

Gibbon.Git.Server/Configuration/UserSettingsService.cs

@@ -24,6 +24,7 @@ public async Task SaveSettings(int userId, UserSettings settings)
         }
 
         entity.PreferredLanguage = settings.PreferredLanguage;
+        entity.PreferredNameFormat = settings.PreferredNameFormat;
 
         await _context.SaveChangesAsync();
 
@@ -43,7 +44,8 @@ public async Task<UserSettings> GetSettings(int userId)
             .Where(u => u.UserId == userId)
             .Select(entity => new UserSettings
             {
-                PreferredLanguage = entity.PreferredLanguage
+                PreferredLanguage = entity.PreferredLanguage,
+                PreferredNameFormat = entity.PreferredNameFormat
             })
             .SingleOrDefaultAsync();
 
@@ -58,7 +60,8 @@ public UserSettings GetDefaultSettings()
     {
         return new UserSettings
         {
-            PreferredLanguage = null
+            PreferredLanguage = null,
+            PreferredNameFormat = NameFormat.LastCommaFirst
         };
     }
 }

Gibbon.Git.Server/Controllers/AccountController.cs

@@ -136,12 +136,33 @@ public async Task<IActionResult> Settings()
             Value = ""
         });
 
+        var nameFormatItems = new List<SelectListItem>
+        {
+            new SelectListItem
+            {
+                Text = Resources.Settings_NameFormat_FirstLast,
+                Value = ((int)Data.Entities.NameFormat.FirstLast).ToString()
+            },
+            new SelectListItem
+            {
+                Text = Resources.Settings_NameFormat_LastCommaFirst,
+                Value = ((int)Data.Entities.NameFormat.LastCommaFirst).ToString()
+            },
+            new SelectListItem
+            {
+                Text = Resources.Settings_NameFormat_LastFirst,
+                Value = ((int)Data.Entities.NameFormat.LastFirst).ToString()
+            }
+        };
+
         var settings = await _userSettingsService.GetSettings(UserModel.Id);
 
         return View(new MeSettingsModel
         {
             PreferredLanguage = settings.PreferredLanguage,
-            AvailableLanguages = cultureItems
+            PreferredNameFormat = settings.PreferredNameFormat,
+            AvailableLanguages = cultureItems,
+            AvailableNameFormats = nameFormatItems
         });
     }
 
@@ -160,12 +181,32 @@ public async Task<IActionResult> Settings(MeSettingsModel settings)
                 })
                 .ToList();
 
+            settings.AvailableNameFormats = new List<SelectListItem>
+            {
+                new SelectListItem
+                {
+                    Text = Resources.Settings_NameFormat_FirstLast,
+                    Value = ((int)Data.Entities.NameFormat.FirstLast).ToString()
+                },
+                new SelectListItem
+                {
+                    Text = Resources.Settings_NameFormat_LastCommaFirst,
+                    Value = ((int)Data.Entities.NameFormat.LastCommaFirst).ToString()
+                },
+                new SelectListItem
+                {
+                    Text = Resources.Settings_NameFormat_LastFirst,
+                    Value = ((int)Data.Entities.NameFormat.LastFirst).ToString()
+                }
+            };
+
             return View(settings);
         }
 
         await _userSettingsService.SaveSettings(UserModel.Id, new UserSettings
         {
-            PreferredLanguage = settings.PreferredLanguage
+            PreferredLanguage = settings.PreferredLanguage,
+            PreferredNameFormat = settings.PreferredNameFormat
         });
 
         return RedirectToAction("Settings");

Gibbon.Git.Server/Data/Entities/NameFormat.cs

@@ -0,0 +1,8 @@
+namespace Gibbon.Git.Server.Data.Entities;
+
+public enum NameFormat
+{
+    FirstLast = 0,
+    LastCommaFirst = 1,
+    LastFirst = 2
+}

Gibbon.Git.Server/Data/Entities/UserSettingsEntity.cs

@@ -9,4 +9,5 @@ public class UserSettingsEntity
     public string TimeZone { get; set; }
     public string DateFormat { get; set; }
     public string DefaultHomePage { get; set; }
+    public NameFormat PreferredNameFormat { get; set; }
 }

Gibbon.Git.Server/Data/EntityConfiguration/UserSettingsEntityConfiguration.cs

@@ -33,5 +33,8 @@ public void Configure(EntityTypeBuilder<UserSettingsEntity> builder)
 
         builder.Property(e => e.DefaultHomePage)
             .HasMaxLength(100);
+
+        builder.Property(e => e.PreferredNameFormat)
+            .HasConversion<int>();
     }
 }

Gibbon.Git.Server/Migrations/SqlServerMigrations/20250930133205_AddPreferredNameFormat.cs

@@ -0,0 +1,29 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace Gibbon.Git.Server.Migrations.SqlServerMigrations
+{
+    /// <inheritdoc />
+    public partial class AddPreferredNameFormat : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.AddColumn<int>(
+                name: "PreferredNameFormat",
+                table: "UserSettings",
+                type: "int",
+                nullable: false,
+                defaultValue: 1);
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropColumn(
+                name: "PreferredNameFormat",
+                table: "UserSettings");
+        }
+    }
+}

Gibbon.Git.Server/Migrations/SqliteMigrations/20250930133205_AddPreferredNameFormat.cs

@@ -0,0 +1,29 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace Gibbon.Git.Server.Migrations.SqliteMigrations
+{
+    /// <inheritdoc />
+    public partial class AddPreferredNameFormat : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.AddColumn<int>(
+                name: "PreferredNameFormat",
+                table: "UserSettings",
+                type: "INTEGER",
+                nullable: false,
+                defaultValue: 1);
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropColumn(
+                name: "PreferredNameFormat",
+                table: "UserSettings");
+        }
+    }
+}