Skip to content

Hmtv2 20 fetch and show scores#9

Open
Essam-Khawaja wants to merge 6 commits intomainfrom
HMTV2-20-fetch-and-show-scores
Open

Hmtv2 20 fetch and show scores#9
Essam-Khawaja wants to merge 6 commits intomainfrom
HMTV2-20-fetch-and-show-scores

Conversation

@Essam-Khawaja
Copy link

Added the ability to seed more round test data, with the following judging criteria: Innovation, Technical Complexity, Design, and Presentation.

One problem I faced was that better auth's generateId() function wasn't working on my seed file. I replaced it with crypto.randomUUID as a placeholder, so I might need to update later.

Frontend show scores component is just the same as the other two tables that connects to a different API endpoint. The API endpoint gets the data already sorted. Had to use some hard typing for the return values because I could not get a proper type to work. This works, but we may need to change it later for cleaner code.

The score is calculated by adding up all the judging rounds for now. I'm assuming this is how we would do it on the day of, but it can be changed if there are different things we need to consider (like a team not doing all rounds, so applying normalization and such, etc)

Anyway, hopefully this is good :)

image

Copy link
Contributor

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments!

@burtonjong
Copy link
Contributor

Also, looks like you changed the lock file:

image

You can fix this by removing your changes to the pnpm-lock file. You could just replace it with the one in main, or delete node_nodules and pnpm-lock and then run pnpm install again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants