Open
Conversation
added 7 commits
November 12, 2025 16:46
bretto36
commented
Nov 12, 2025
composer.lock
Outdated
Contributor
Author
There was a problem hiding this comment.
Shouldn't commit the composer lock file, have removed so the tests.yml will work
bretto36
commented
Nov 12, 2025
| "orchestra/testbench": "^8.0 || ^9.0 || ^10.0", | ||
| "laminas/laminas-code": "^4.8.0", | ||
| "nunomaduro/collision": "^8.1", | ||
| "symplify/easy-ci": "^10.0", |
Contributor
Author
There was a problem hiding this comment.
this is abandoned now
bretto36
commented
Nov 12, 2025
| /** | ||
| * Class Soap. | ||
| * | ||
| * @method static \CodeDredd\Soap\Handler\HttPlugHandle getHandler() |
Contributor
Author
There was a problem hiding this comment.
missing file so removed reference
Contributor
Author
|
@CodeDredd Are you able to take a look at this one and give me any feedback please. Thank you |
Contributor
Author
|
@CodeDredd any idea when you'll have time for this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Deprecation warnings on PHP 8.4
What I did
Changed the deprecated sections and also got tests working. The versions we allow for php-soap/psr18-transport only support php 8.2 upwards. So i adjusted tests
How to test
I have made the changes to match the new requirements
If your answer is yes to any of these, please make sure to include it in your PR.