feat: add asset watcher and sponsor logo embedding support#4
Merged
Conversation
- Watch assets/ directory during pnpm dev for automatic rebuilds - Document relative image path patterns for local and GitHub Pages - Add gitflow reminder to workflow section in README
There was a problem hiding this comment.
Pull request overview
Adds automatic asset rebuilding for the dev server, documents image-embedding conventions for sponsor logos, reinforces gitflow guidance in the README, and ships the first set of CodeHub sponsor logos used on the new "Our sponsors" slide.
Changes:
- Extend
scripts/dev.mjswith a recursiveassets/directory watcher, a debounced rebuild queue, and a root-level watcher to react when theassets/directory itself is created/renamed. - Update
slides.mdto add an "About me", sponsor logos section, and restructured "Why home networking matters" slide; add README guidance for image paths and gitflow. - Add sponsor logo assets (PNG, WEBP, SVG) under
assets/sponsors/.
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/dev.mjs | Adds recursive assets watcher and debounced rebuild logic |
| slides.md | New about-me/sponsors content and restructured pain-points slide |
| README.md | Documents image embedding, sponsor paths, and gitflow workflow |
| assets/sponsors/sponsors-tuppenny-well.svg | New SVG sponsor logo asset |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
pnpm devnow rebuilds automatically when files inassets/change, enabling smooth sponsor logo updates during local development../assets/sponsors/...) that work both locally and on GitHub Pages.developbefore making changes.assets/sponsors/.Why
This unblocks adding sponsor logos to the second slide while ensuring the build, local development, and GitHub Pages deployment all display images correctly.