Conversation
anandkumarpatel
left a comment
anandkumarpatel
left a comment
There was a problem hiding this comment.
Would be cool if you added ponos and made this a worker server which listens to khronos for the 5 min event so you dont have to deal with cron. just 1 extra file :)
| if (DRY_RUN) { | ||
| console.log(JSON.stringify(postData)) | ||
| } | ||
| log.debug({ postData }, 'DRY RUN: Data to be posted to cloudwatch') |
There was a problem hiding this comment.
dry run? dry run was removed here
There was a problem hiding this comment.
Yeah, I just made these debug statements. So you just have to change the level. Will remove the DRY RUN stuff from the log message.
The thing I don't like about this is that now we're running a node container 100% of the time (with the associated memory implications, for just a cron job). Maybe we should stick furry-cactus in palantiri as a worker? That's where it seems it should go. Then we don't pay for the overhead of running a ponos server. I don't think the ponos server is THAT big of a deal, but I do think we could do a better job of managing this. |
2 participants
No description provided.