Stop using outdated feature gates#31
Stop using outdated feature gates#31CodeSandwich merged 3 commits intoCodeSandwich:masterfrom rye:no-use_extern_macros
Conversation
This is done because it was stabilized in 1.30.
|
Hi @rye, |
|
@CodeSandwich, sounds good! I have also noticed that this project is using the Should I update those in this PR as well? I can also make another one. |
|
Oh, you're right, the CI got worse. I've stopped paying attention to the error messages and the went from single failing test to compilation failure. Of course, if you have time, please add fix to this as well, that's very much appreciated. |
See commit d3c902f3113575b134641c14a9734b5075d06b09 in rust-lang/rust, which was released in version 1.30.0. (I think.) Cleans up a bunch of `cargo test` errors and allows CI to actually run. Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
rye
changed the title
I'm not even sure we need this, but since this feature gate hasn't been stabilized I guess we still need this. (If I remove #![feature(proc_macro_hygiene)] from the tests, the builds go red.) Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
|
@CodeSandwich, just so you know I went ahead and update the usage of |
|
I'm very sorry, but since a few days and for a few more I will not be able to work on Mocktopus. I will gladly come back to coding, reviewing and discussing when my personal situation gets a bit more stable and less time consuming. |
2 participants
This feature was stabilized in Rust 1.30.0?
See rust-lang/rust#50911, and the release notes for 1.30.0 which include that PR.
See also rust-lang/rust@d3c902f, which merged the
proc_macro_*macros into oneproc_macro_hygienefeature gate.