Add comprehensive Copilot instruction documentation and navigation#241
Add comprehensive Copilot instruction documentation and navigation#241rezwana-karim merged 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: rezwana-karim <126201034+rezwana-karim@users.noreply.github.com>
Co-authored-by: rezwana-karim <126201034+rezwana-karim@users.noreply.github.com>
Co-authored-by: rezwana-karim <126201034+rezwana-karim@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds missing navigation and onboarding documentation for the repository’s existing Copilot instruction system (repo-wide + path-specific instructions, custom agents, prompts, skills) and documents MCP-first usage patterns.
Changes:
- Added
.github/README.md,.github/COPILOT_QUICKSTART.md, and.github/COPILOT_SETUP_SUMMARY.mdto document and index the Copilot instruction system and MCP workflows. - Extended
.github/copilot-instructions.mdwith an instruction-system overview, MCP best practices, and Playwright MCP usage notes. - Updated
.github/agents/AGENTS_INDEX.jsonto include additional agents in the catalog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/copilot-instructions.md | Adds instruction system overview + MCP/Playwright guidance and cross-references. |
| .github/agents/AGENTS_INDEX.json | Extends the agent catalog entries. |
| .github/README.md | New index/navigator for instructions, agents, prompts, skills, and MCP servers. |
| .github/COPILOT_SETUP_SUMMARY.md | New implementation/maintenance summary of the instruction setup. |
| .github/COPILOT_QUICKSTART.md | New developer/agent onboarding quickstart and troubleshooting guide. |
.github/README.md
Outdated
| - **`typescript-mcp-server.instructions.md`** - MCP server development with TypeScript | ||
| - Applies to: `**/*.ts, **/*.js, **/package.json` | ||
| - **`nodejs-javascript-vitest.instructions.md`** - Node.js with Vitest testing | ||
| - Applies to: `**.ts, **.js, **.mjs, **.cjs` |
There was a problem hiding this comment.
The listed applyTo patterns for nodejs-javascript-vitest.instructions.md don’t match the instruction file frontmatter (it applies to **/*.js, **/*.mjs, **/*.cjs, not **.ts, **.js, ...). Please copy the exact applyTo glob(s) from the instruction file to avoid misleading readers.
| - Applies to: `**.ts, **.js, **.mjs, **.cjs` | |
| - Applies to: `**/*.js, **/*.mjs, **/*.cjs` |
There was a problem hiding this comment.
Fixed in c3b23e6. Updated to match exact applyTo pattern from instruction file frontmatter: **/*.js, **/*.mjs, **/*.cjs
.github/COPILOT_QUICKSTART.md
Outdated
| RESEND_API_KEY="re_dummy_key_for_build" # Required even for build! | ||
| ``` | ||
|
|
||
| **⚠️ CRITICAL:** Build will fail without `RESEND_API_KEY` even with a dummy value. | ||
|
|
There was a problem hiding this comment.
This guide says the build will fail without RESEND_API_KEY, but src/lib/auth.ts now uses lazy initialization and logs a dev magic link when the key is missing. Update this guidance to reflect the current behavior (build should succeed; email sending is disabled/logged).
There was a problem hiding this comment.
Fixed in c3b23e6. Updated guidance to reflect lazy initialization behavior - build succeeds without the key, and magic links are logged to console instead of being emailed.
.github/COPILOT_QUICKSTART.md
Outdated
| **Error:** Build fails with "Cannot find module 'resend'" | ||
| **Fix:** Add `RESEND_API_KEY="re_dummy_key_for_build"` to `.env.local` |
There was a problem hiding this comment.
“Missing RESEND_API_KEY” troubleshooting currently says the build fails with "Cannot find module 'resend'", but that error indicates a dependency resolution issue, not a missing API key. Consider updating the error text to match the actual runtime warning/log behavior when RESEND_API_KEY is unset.
| **Error:** Build fails with "Cannot find module 'resend'" | |
| **Fix:** Add `RESEND_API_KEY="re_dummy_key_for_build"` to `.env.local` | |
| **Behavior:** Auth email sending is disabled and magic links are logged to the console because `RESEND_API_KEY` is not set | |
| **Fix:** Add `RESEND_API_KEY="re_dummy_key_for_build"` to `.env.local` (a dummy value is fine for local development) |
There was a problem hiding this comment.
Fixed in c3b23e6. Updated troubleshooting to describe actual runtime behavior: "Auth email sending is disabled and magic links are logged to the console because RESEND_API_KEY is not set"
.github/COPILOT_SETUP_SUMMARY.md
Outdated
| # Copilot Instructions Setup - Implementation Summary | ||
|
|
||
| **Date:** February 14, 2026 | ||
| **Issue:** #[Issue Number] - ✨ Set up Copilot instructions |
There was a problem hiding this comment.
Line still contains a placeholder issue reference (#[Issue Number]). Replace it with the actual issue number (per PR description: #240) or remove the issue line if it’s meant to be a reusable template.
| **Issue:** #[Issue Number] - ✨ Set up Copilot instructions | |
| **Issue:** #240 - ✨ Set up Copilot instructions |
.github/COPILOT_SETUP_SUMMARY.md
Outdated
| #### Updated Configuration (1) | ||
| 4. **`.github/agents/AGENTS_INDEX.json`** (Updated) | ||
| - Added 3 missing agents (Planer, agentic-workflows, web-design-guidelines-agent) | ||
| - Now includes all 26 custom agents |
There was a problem hiding this comment.
This section claims AGENTS_INDEX.json now includes “all 26 custom agents”, but there are currently 25 .agent.md files under .github/agents/. Update the stated total (or add the missing agent entry/file) so the summary matches the repo.
| - Now includes all 26 custom agents | |
| - Now includes all 25 custom agents |
There was a problem hiding this comment.
Fixed in c3b23e6. Corrected count to 25 agents (verified with ls .github/agents/*.md | wc -l).
.github/copilot-instructions.md
Outdated
| ### Custom Agents (26 available) | ||
| - **Planning**: Planer, task-planner, task-researcher, implementation-plan | ||
| - **Development**: expert-nextjs-developer, expert-react-frontend-engineer, typescript-mcp-expert | ||
| - **Testing**: playwright-tester, tdd-red, tdd-green, tdd-refactor | ||
| - **Quality**: se-security-reviewer, se-system-architecture-reviewer, web-design-guidelines-agent | ||
| - **DevOps**: se-gitops-ci-specialist, github-actions-expert, postgresql-dba | ||
|
|
||
| See `.github/agents/` for all available agents. |
There was a problem hiding this comment.
The doc says “Custom Agents (26 available)”, but .github/agents/ currently contains 25 .agent.md files. Please update the stated count (or add the missing agent) so the repository-wide instructions stay accurate.
There was a problem hiding this comment.
Fixed in c3b23e6. Corrected count to 25 agents to match actual files in .github/agents/.
.github/README.md
Outdated
| .github/ | ||
| ├── copilot-instructions.md # Repository-wide instructions | ||
| ├── instructions/ # Path-specific instructions (18 files) | ||
| ├── agents/ # Custom agent definitions (26 agents) |
There was a problem hiding this comment.
Directory structure claims “Custom agent definitions (26 agents)”, but there are currently 25 .agent.md files in .github/agents/. Adjust the count (or add the missing agent) to keep this index accurate.
| ├── agents/ # Custom agent definitions (26 agents) | |
| ├── agents/ # Custom agent definitions (25 agents) |
There was a problem hiding this comment.
Fixed in c3b23e6. Updated directory structure to show 25 agents.
|
@copilot apply changes based on the comments in this thread |
…EY guidance, fix applyTo pattern Co-authored-by: rezwana-karim <126201034+rezwana-karim@users.noreply.github.com>
✅ Set up Copilot Instructions - Review Fixes Applied
Summary
Addressed all 7 PR review comments from copilot-pull-request-reviewer.
Changes Made
1. Fixed Agent Count (25, not 26)
Files Updated:
.github/README.md- Updated directory structure and Custom Agents section.github/copilot-instructions.md- Updated Custom Agents count.github/COPILOT_SETUP_SUMMARY.md- Updated 3 occurrences of agent countRoot Cause: There are 25 agent files (24
.agent.mdfiles + 1ui-ux-saas-specialist-agent.md), not 26.Verified Count:
2. Updated RESEND_API_KEY Guidance
Files Updated:
.github/COPILOT_QUICKSTART.mdChanges:
Root Cause: The code now uses lazy initialization (
getResend()) which logs magic links to console whenRESEND_API_KEYis missing, rather than failing at build time.Evidence:
src/lib/auth.tslines 14-26 show lazy initialization with console warning when API key is not set.3. Fixed applyTo Pattern for nodejs-javascript-vitest.instructions.md
File Updated:
.github/README.mdChange:
Root Cause: Copied exact pattern from instruction file frontmatter to match actual behavior.
Evidence:
.github/instructions/nodejs-javascript-vitest.instructions.mdline 3 showsapplyTo: '**/*.js, **/*.mjs, **/*.cjs'4. Fixed Placeholder Issue Number
File Updated:
.github/COPILOT_SETUP_SUMMARY.mdChange:
Review Comments Addressed
✅ Comment 2807821298 (README.md:52)
Fixed applyTo pattern to match instruction file frontmatter exactly.
✅ Comment 2807821310 (COPILOT_QUICKSTART.md:26-30)
Updated guidance to reflect lazy initialization - build succeeds without key, emails logged instead.
✅ Comment 2807821313 (COPILOT_QUICKSTART.md:199-200)
Updated troubleshooting to reflect actual runtime behavior when RESEND_API_KEY is unset.
✅ Comment 2807821318 (COPILOT_SETUP_SUMMARY.md:4)
Replaced placeholder with actual issue number #240.
✅ Comment 2807821323 (COPILOT_SETUP_SUMMARY.md:42)
Corrected agent count from 26 to 25.
✅ Comment 2807821328 (copilot-instructions.md:284-291)
Corrected agent count from 26 to 25.
✅ Comment 2807821331 (README.md:11)
Corrected agent count from 26 to 25 in directory structure.
Verification
Agent Count Verification
RESEND_API_KEY Behavior Verification
From
src/lib/auth.ts:File Changes Summary
Status
✅ All 7 PR review comments addressed
✅ All changes verified
✅ Documentation accuracy restored
✅ Ready for merge
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.