App UI Tweaks - Zod Schemas#907
Conversation
upstream listed the wrong library as their dependency and now we have to fix it
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a multi-faceted improvement of the SparkyFitness application, touching both the mobile frontend and the Node.js backend. The primary goal is to refine the mobile app's user interface for a smoother experience and to meet specific requirements for platform reviews. Concurrently, the backend's measurement APIs have been fortified with Zod for enhanced data validation, ensuring greater stability and correctness. Significant effort was also put into updating developer documentation to streamline onboarding and ongoing development across the monorepo. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request significantly refactors documentation across the monorepo, introducing new AGENTS.md files at both the root and SparkyFitnessMobile package level to provide structured guidance for coding agents. In the SparkyFitnessMobile app, several UI components were refined for better visual consistency and layout, including adjustments to padding, text colors, and the introduction of a new MacroSummaryCard component using Skia for progress visualization. The FoodEntryViewScreen was updated to pin the delete button to the bottom, and the DashboardScreen, DiaryScreen, SettingsScreen, and SyncScreen were adjusted for safe area insets and scroll behavior. Additionally, the mobile app's HealthKit seeding functionality was expanded to include hydration, body temperature, and flights climbed. On the SparkyFitnessServer side, API endpoints related to measurements (water intake, check-ins, custom measurements) were updated to use Zod schemas for robust input validation, replacing manual checks, and their Swagger documentation was refined to reflect these changes and new fields. A critical issue was identified where the POST /check-in endpoint incorrectly ignored the user_id from the request body, preventing authorized users from creating check-in entries for others, which requires correction to align with intended functionality and consistency with other endpoints. Another minor UI issue was noted on the DashboardScreen where the "Health Trends" title has an unusually large top margin (mt-24), suggesting a potential typo that should be reduced for a more compact layout.
Tip
Help us review and merge your PR faster!
Please ensure you have completed the Checklist below.
For Frontend changes, please run
pnpm run validateto check for any errors.PRs that include tests and clear screenshots are highly preferred!
Description
UI Tweaks for screenshots for apple review
Related Issue
PR type [ ] Issue [ ] New Feature [ ] Documentation
Linked Issue: #
Checklist
Please check all that apply:
pnpm run validate(especially for Frontend).en) translation file (if applicable).rls_policies.sqlfor any new user-specific tables.Screenshots (if applicable)
Before
[Insert screenshot/GIF here]
After
[Insert screenshot/GIF here]