London 10-Mahendra Balal-javascript core 1-coursework-week2

[mabalal]

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

• Your Name:
• Your City:
• Your Slack Name:

Homework Details

• Module:
• Week:

Notes

• What did you find easy?

• What did you find hard?

• What do you still not understand?

• Any other notes?

[berkeli]

There's a pattern in programming to simplify if .. else statements. You can rewrite this block as follows:

 if (isHappy) {
    return "I am happy";
  }

return "I am not happy";

the pattern is called return early pattern, and you can read more here https://medium.com/swlh/return-early-pattern-3d18a41bba8

[berkeli]

this works fine, but you could make it 2x more performant by skipping over even numbers. For example:

Suggested change

	function printOddNumbers(limit) {
	let i = 1;
	while (i <= limit) {
	if(i % 2 !==0) {
	console.log(i);
	}
	i++;
	}
	}
	function printOddNumbers(limit) {
	let i = 1;
	while (i <= limit) {
	console.log(i);
	i+=2;
	}
	}

[berkeli]

Nice add, always good to handle edge cases even if the exercise didn't mention it

[berkeli]

I think this can be simplified with the following:

Suggested change

	let totalPrice = price1 + price2;
	let discount = Math.min(price1, price2);
	let discountedPrice = totalPrice - discount;
	return discountedPrice;
	return Math.max(price1, price2);

What do you think?

[berkeli]

Nice work @mabalal, I left a few minor comments