This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London 9 -Tuan Nguyen-JS-core1-week2#454
Open
Jacknguyen4438 wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London 9 -Tuan Nguyen-JS-core1-week2#454Jacknguyen4438 wants to merge 1 commit intoCodeYourFuture:mainfrom
Jacknguyen4438 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
homework commit
Jacknguyen4438
changed the title
VicJerUk
suggested changes
Apr 6, 2023
|
|
||
| function greaterThan10(num) { | ||
| let isBigEnough; | ||
| let isBigEnough=num; |
There was a problem hiding this comment.
Looks good but I'm wondering whether you can make it better? You did similar changes already in the getMood function. Would that work here too?
Comment on lines
+83
to
+88
| function countReverse(number) { | ||
| while (number >0){ | ||
| console.log(number); | ||
| }; | ||
| number=number-1; | ||
| }; |
There was a problem hiding this comment.
Good effort but are you sure this is correct? When you ran this code locally did it work for you correctly?
Look closely what you are trying to do with number parameter. Current code will result in never ending loop and will never complete is there a better way?
Hint: Have a look at your printOddNumbers function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details
Notes
What did you find easy? Understand of to use compare and logical operator
What did you find hard? Doing with while loop
What do you still not understand? No answer
Any other notes? No answer