-
-
Notifications
You must be signed in to change notification settings - Fork 29
London | SDC-Nov-25 | Emiliano Uruena | Sprint 2 | Linked List Python #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Emilianouz
wants to merge
3
commits into
CodeYourFuture:main
Choose a base branch
from
Emilianouz:Sprint2-linked-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # `push_head` should add an element to the start of the list. It should return something that can be passed to | ||
| # `remove` to remove that element in the future. | ||
| # `pop_tail` should remove an element from the end of the list. | ||
| # `remove` takes a handle from `push_head`, and removes that element from the list. | ||
|
|
||
| class Node: | ||
| def __init__(self, value): | ||
| self.value = value | ||
| self.prev = None | ||
| self.next = None | ||
|
|
||
|
|
||
| class LinkedList: | ||
| def __init__(self): | ||
| self.head = None | ||
| self.tail = None | ||
|
|
||
| # adding a new value in the front of the list | ||
| def push_head(self, value): | ||
| node = Node(value) | ||
|
|
||
| if self.head is None: # if list is empty head and tail becomes this node. | ||
| self.head = node | ||
| self.tail = node | ||
| else: | ||
| node.next = self.head | ||
| self.head.prev = node | ||
| self.head = node | ||
|
|
||
| return node # returns the node so we can remove it later | ||
|
|
||
| # removing last element | ||
| def pop_tail(self): | ||
| if self.tail is None: | ||
| raise Exception("List is empty") | ||
|
|
||
| value = self.tail.value # value to return | ||
|
|
||
| if self.head == self.tail: # if only one element | ||
| self.head = None | ||
| self.tail = None | ||
| else: | ||
| self.tail = self.tail.prev # move tail back | ||
| self.tail.next = None # remove old tail connection | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could consider delegating the node removing task to |
||
|
|
||
| return value | ||
|
|
||
| # removes a specific node | ||
| def remove(self, node): | ||
|
|
||
| if node.prev is None: # if removing head | ||
| self.head = node.next | ||
| else: | ||
| node.prev.next = node.next # connect previous to next | ||
|
|
||
| if node.next is None: # if removing tail | ||
| self.tail = node.prev | ||
| else: | ||
| node.next.prev = node.prev # connect next to previous | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests in the
linked_list_test.pyexpect the properties named in certain way.