Skip to content

Glasgow| 26-ITP-JAN |Alasdair MacDonald | Sprint 3 | Alarm Clock #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MacDonald91 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Glasgow| 26-ITP-JAN |Alasdair MacDonald | Sprint 3 | Alarm Clock #1039

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f63885
Build alarm clock countdown functionality with sound and stop feature
MacDonald91 Mar 18, 2026
b5c66ef
fix: correct time formatting for minutes and seconds
MacDonald91 Mar 21, 2026
b9165a5
Fix: alarmclock validation, formatting, and missing function
MacDonald91 Apr 15, 2026
82e848d
Merge branch 'main' into coursework/alarm-clock
MacDonald91 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Copy link
Copy Markdown

@WeiTsungCheng WeiTsungCheng Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. playAlarm() no definition
  2. Inconsistent time formats

Copy link
Copy Markdown

@WeiTsungCheng WeiTsungCheng Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parseInt(input)
if user enter character instead of Int?

Copy link
Copy Markdown
Author

@MacDonald91 MacDonald91 Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!

I’ve made the following updates:

  • Added a definition for playAlarm() to resolve the missing function issue.
  • Standardised the time display format to mm:ss for consistency throughout.
  • Replaced parseInt() with Number() and added validation to handle invalid user input (e.g. non-numeric values).
  • Improved overall structure to make the timer logic clearer and more maintainable.

Let me know if there’s anything else I can improve.

Original file line number Diff line number Diff line change
@@ -1,7 +1,40 @@
function setAlarm() {}
function setAlarm() {
const input = document.getElementById("alarmSet").value;

if (!input || input <= 0) {
alert("Please enter a valid number");
return;
}

let timeRemaining = parseInt(input);
const display = document.getElementById("timeRemaining");

const minutes = Math.floor(timeRemaining / 60);
const seconds = timeRemaining % 60;

display.textContent = `Time Remaining: ${String(minutes).padStart(2, "0")}:${String(seconds).padStart(2, "0")}`;

// Clear any previous timer
clearInterval(countdown);

countdown = setInterval(() => {
timeRemaining--;

display.textContent = `Time Remaining: 00:${timeRemaining
.toString()
.padStart(2, "0")}`;

if (timeRemaining === 0) {
clearInterval(countdown);
playAlarm();
}
}, 1000);
}

// DO NOT EDIT BELOW HERE

let countdown; // 👈 needed for timer control

var audio = new Audio("alarmsound.mp3");

function setup() {
Expand All @@ -20,6 +53,7 @@ function playAlarm() {

function pauseAlarm() {
audio.pause();
clearInterval(countdown);
}

window.onload = setup;
window.onload = setup;
Loading