London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| alarm clock

[alexandru-pocovnicu]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

implemented an alarm clock that counts down from the input value

[cjyuan]

Code works fine if a user only clicks the "Set Alarm" button once.
However, if the user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly.
Can you fix the issue?

---

Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.

Consider introducing a dedicated reset function to return the app to a clean initial state to help ensure consistency.

[alexandru-pocovnicu]

when i press stopalarm i want the countdown to go to 0,call pauseAlarm(), and the class to be removed from the body,but on line 48 i have this message // DO NOT EDIT BELOW HERE, I can't really think of a way of doing it without adding code bellow that

[cjyuan]

Note: To reset countdown display when the user clicks "Stop", and without modifying existing code, you can add another event listener to the stop button:

  document.getElementById("stop").addEventListener("click", () => {
    // Your code here ...
  });

[cjyuan]

Other changes look good.

[cjyuan]

1. Move remainingSeconds = totalSeconds; out of updateCountDown() and replace totalSeconds in the function by remainingSeconds so that the function depends only on remainingSeconds.

2. Move updateCountDown() to outer scope so that it can be used by pauseCountDown().

That is,

function updateCountDown() {
   ...
}

function setAlarm() {
  // Code to deal with input
  ...

  remainingSeconds = totalSeconds;  // Initialise the global countdown number

  // Display the timer and start the countdown
  updateCountDown();
  intervalId = setInterval(updateCountDown, 1000);
}

[cjyuan]

This is supposed to be "continuing the countdown". So it can be replaced by

  updateCountDown();
  intervalId = setInterval(updateCountDown, 1000);

---

Note: Currently, finishCountDown() is not called when remainingSeconds reaches zero.