Sheffield | 26-ITP-Jan | Mona -Eltantawy | Sprint 1 | Data- Groups/sprint 1#1076
Open
Mona-Eltantawy wants to merge 14 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mona -Eltantawy | Sprint 1 | Data- Groups/sprint 1#1076Mona-Eltantawy wants to merge 14 commits intoCodeYourFuture:mainfrom
Mona-Eltantawy wants to merge 14 commits intoCodeYourFuture:mainfrom
Conversation
…ications and to return the same values if the array has no dublications.
…, arry with nigative and positive number, arry with non numerical values and arry with decimels.
…e test and get all tests passed.
Mona-Eltantawy
added
the
Needs Review
cjyuan
reviewed
Mar 24, 2026
cjyuan
added
Reviewed
…BeCloseTo ) instead for handeling the floating ans decimal issues.
Mona-Eltantawy
added
the
Needs Review
cjyuan
reviewed
Apr 13, 2026
Comment on lines
+1
to
6
| function findMax(arr) { | ||
| return arr | ||
| .filter((item) => typeof item === "number" && Number.isFinite(item)); | ||
| if(numbers.length=== 0) return null; | ||
| return numbers.reduce((acc, num) => (num > acc ? num : acc), -Infinity); | ||
| } |
Contributor
There was a problem hiding this comment.
This function is not working as expected. Can you fix it?
Author
There was a problem hiding this comment.
I fixed it . Thanks CJ .
cjyuan
removed
the
Needs Review
Mona-Eltantawy
added
the
Needs Review
cjyuan
reviewed
Apr 14, 2026
| .filter((item) => typeof item === "number" && Number.isFinite(item)); | ||
| if(numbers.length=== 0) return null; | ||
| return numbers.reduce((acc, num) => (num > acc ? num : acc), -Infinity); | ||
| .filter((item) => typeof item === "number" && Number.isFinite(item)) |
Contributor
There was a problem hiding this comment.
Note: Number.isFinite(item) also checks typeof item === "number"
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist